Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIMO using inconsisten plotting layout between time/freq plots #607

Open
albheim opened this issue Jan 21, 2022 · 2 comments
Open

MIMO using inconsisten plotting layout between time/freq plots #607

albheim opened this issue Jan 21, 2022 · 2 comments

Comments

@albheim
Copy link
Member

albheim commented Jan 21, 2022

For time domain plots it seems like we get one plot per output, and all inputs for each output are sharing that plot.

For freq domain it seems like it is one per input output combination.

Not sure if this has been a conscious choice, or just happened at some point. Don't think it has always been like this, maybe introduced when introducing the plot(simobject) syntax for time domain?

@baggepinnen
Copy link
Member

Yep, I think the change was introduced then. Perhaps it's better to have plots ny x nu like it was before, it get's hard to see when there are multiple responses in the same pane.

@albheim
Copy link
Member Author

albheim commented Jan 21, 2022

Consistency over different plot calls is nice, so I think either changing time plots or freq plots would be nice.

I also feel it is more consistent to treat inputs and outputs the same, since it is not obvious to me why you would have this instead of one for each input and collect the corresponding outputs in the same plot? So either all in same plot (maybe messy?) or one plot each.

But I don't have very strong feelings about it, and I probably won't put time into fixing it myself. Just noticed it and though it seemed odd so put it up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants