Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MutableBinaryHeap{T} when T is Union/abstract #869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cmcaine
Copy link
Contributor

@cmcaine cmcaine commented Aug 26, 2023

Each MutableBinaryHeapNode needs to be explicitly parameterised or they can end up being parameterised by a type that doesn't match the Heap when T is not concrete, and then Julia will (rightly) throw a conversion error when trying to add them to MutableBinaryHeap's nodes field.

Each MutableBinaryHeapNode needs to be fully parameterised or Julia will
throw a conversion error when trying to add them to MutableBinaryHeap's
nodes field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant