Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of scitype for "points on a manifold" #128

Open
ablaom opened this issue Sep 16, 2020 · 6 comments
Open

Add implementation of scitype for "points on a manifold" #128

ablaom opened this issue Sep 16, 2020 · 6 comments

Comments

@ablaom
Copy link
Member

ablaom commented Sep 16, 2020

The tentative suggestion is that scitype((p, M)) = ManifoldPoint{typeof(M)} whenever M isa Manifolds.Manifold.

Context:JuliaManifolds/ManifoldML.jl#3
Requires: #114

ablaom referenced this issue in JuliaAI/MLJScientificTypes.jl Sep 23, 2020
@ablaom
Copy link
Member Author

ablaom commented Sep 23, 2020

Specifically:

ST.scitype(::Tuple{Any,MT}) where MT<:ManifoldsBase.Manifold = ManifoldPoint{MT}

This is implemented on the manifolds branch. Look at these tests to get an idea of behaviour.

@ablaom
Copy link
Member Author

ablaom commented Sep 23, 2020

@mateuszbaran @kellertuer I propose you add MLJScientificTypes to your dev project and pin to the manifolds branch until we're sure this is the best approach. Yes?

@kellertuer
Copy link

I think that looks good and should work.

@ablaom ablaom transferred this issue from JuliaAI/MLJScientificTypes.jl Jun 21, 2021
@ablaom
Copy link
Member Author

ablaom commented Jul 20, 2021

@mateuszbaran @kellertuer

Been a while. Here's an update from our end: The manifold branch referred to above is now part of an archived repo - a casualty of the renaming MLJScientificTypes -> ScientificTypes and ScientificTypes -> ScientificTypesBase. For the record the relevant commit is here:

JuliaAI/MLJScientificTypes.jl@4411140

And ManifoldPoint{MT} is already in ScientificTypesBase.

I can create a new PR if there is still interest to do some integration. What is the status of this at your end?

@kellertuer
Copy link

We would still be interested of course – I just got carried away from the ManifoldsML package due to a few features on Manifolds and moving to a new university/country.

@mateuszbaran
Copy link

Thanks for an update! I'm still interested in developing ManifoldsML further, it just happened that I don't currently need to apply traditional machine learning to manifold-valued data. I'm currently working towards continuous normalizing flows on manifolds because it's more relevant to one of the projects I'm currently working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants