Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing MLJBase to receive logger instances #925

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

pebeto
Copy link
Member

@pebeto pebeto commented Aug 16, 2023

This PR contains the changes related to functions that can be extended by any logger projects (in this case, mlflow). It contains:

  • A log_evaluation function that receives a logger instance and a performance evaluation. It can be extended by any project that logs to a platform.
  • Adapting MLJBase functions that receive logger as argument.

This changes can be seen applied in MLJFlow.jl.

Useful links:

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.78%. Comparing base (f808e98) to head (8b6b047).
Report is 175 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #925      +/-   ##
==========================================
+ Coverage   87.77%   87.78%   +0.01%     
==========================================
  Files          40       40              
  Lines        3656     3659       +3     
==========================================
+ Hits         3209     3212       +3     
  Misses        447      447              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom
Copy link
Member

ablaom commented Aug 16, 2023

@ablaom to confirm extra testing:

  • MLJTestIntegration/example/bigtest/notbook.jl

@ablaom
Copy link
Member

ablaom commented Aug 17, 2023

Can we also:

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@ablaom ablaom merged commit 6726f67 into JuliaAI:dev Aug 18, 2023
3 checks passed
This was referenced Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants