Skip to content
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.

Geometry cutting of voronoi polygons for global IFD #189

Open
schroedtert opened this issue Apr 30, 2021 · 3 comments
Open

Geometry cutting of voronoi polygons for global IFD #189

schroedtert opened this issue Apr 30, 2021 · 3 comments

Comments

@schroedtert
Copy link
Member

Currently the room containing a particular measurement area will be detected and the resulting voronoi diagram will be cut at the borders of this room. Some issues arise from this when using the global IFD:

  • room detection doesn't make sense when computing global IFD as the voronoi diagrams need to be cut at all walls not just one room
  • as the walls might not have any thickness we can not differentiate between wall and door, which would mean that voronoi polygons will be cut at doors. Other drawback of not having a thickness: We can't merge all rooms together as than the walls between rooms get lost.
  • alternative: is the global IFD not the same as putting a measurement area in each room, which covers the whole area of that room?
@gjaeger
Copy link
Contributor

gjaeger commented May 1, 2021

alternative: is the global IFD not the same as putting a measurement area in each room, which covers the whole area of that room?

@schroedtert No, the global IFD should be room independent. Voronoi area should depend only on the geometry, not in the definition of the rooms.

@chraibi
Copy link
Member

chraibi commented May 1, 2021

I did not know that doors are relevant when cutting Voronoi diagrams.

room detection doesn't make sense when computing global IFD as the voronoi diagrams need to be cut at all walls not just one room

Probably it makes sense with regards to computing time?

@schroedtert
Copy link
Member Author

@schroedtert No, the global IFD should be room independent. Voronoi area should depend only on the geometry, not in the definition of the rooms.

This would just be a quick and dirty fix. But has the drawback, that artifacts will occur at the doors, as the voronoi diagrams will be cut there.

I did not know that doors are relevant when cutting Voronoi diagrams.

They should not, but as we cut the voronoi polygon with the boundary of the geometry/room the doors are also included.

Probably it makes sense with regards to commuting time?

From a first glance at the code, this would still lead to wrong results in a multiroom setup. Haven't verified it yet, though.

@Ozaq Ozaq transferred this issue from PedestrianDynamics/jupedsim Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants