Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance still_water_surface and bathymetry #133

Open
ranocha opened this issue Aug 14, 2024 · 0 comments
Open

Enhance still_water_surface and bathymetry #133

ranocha opened this issue Aug 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ranocha
Copy link
Collaborator

ranocha commented Aug 14, 2024 •
edited
Loading

We could consider adding

varnames(::typeof(still_water_surface), equations) = ("η_0",)

and similarly for bathymetry further down. If we do this, we should also add them to the conversion_functions in the unit tests.

Originally posted by @JoshuaLampert in #127 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ranocha