Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would this work with Regex? #1

Open
FM1337 opened this issue Apr 29, 2019 · 5 comments
Open

Would this work with Regex? #1

FM1337 opened this issue Apr 29, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@FM1337
Copy link

FM1337 commented Apr 29, 2019

Let's say I have a list like this https://raw.githubusercontent.com/kwsch/PKHeX/master/PKHeX.Core/Resources/text/locale/badwords.txt

Would this work with your swear filter library?

@FM1337
Copy link
Author

FM1337 commented Apr 29, 2019

nvm this was a stupid question

@FM1337 FM1337 closed this as completed Apr 29, 2019
@JoshuaDoes
Copy link
Owner

I'm afraid it won't work as it currently stands, however that's not to say it can't work o:

You just gave me a great idea: Adding pure regular expression support, as simply creating a list of words in an array will still count as a valid list of regular expressions in an array to the regex parser.

I'm going to re-open this for the time being to make sure I keep my attention to it and can get around to this sometime soon

@JoshuaDoes JoshuaDoes reopened this Apr 30, 2019
@JoshuaDoes JoshuaDoes added the enhancement New feature or request label Apr 30, 2019
@boosh
Copy link

boosh commented Oct 23, 2021

Implemented in https://github.com/boosh/swearfilter

@JoshuaDoes
Copy link
Owner

Implemented in https://github.com/boosh/swearfilter

It's MIT but I still wanna ask, mind if I cherry pick your commits? I'll edit them before pushing to remove repo-breaking changes and follow it with a credits list commit for you and a previous fork that I gave the same treatment to, as well as keep full authorship for your commits (as you can see in the commit history for contributors).

I'm also going to consider renaming the repo to be a little more professional, as it seems to be a primary reason for people to fork the repo (so I imagine cloners are renaming their imports too). I don't think I need to explain the joke behind the current name, but it might help if I make it match the package name to begin with.

@boosh
Copy link

boosh commented Nov 11, 2021

Yeah no worries. The issue with the repo name wasn't the name itself, it's that because the actual golang package name is different to the GH repo name it was tripping up using it in a go.mod file. It's just easier to rename the repo to match the golang package name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants