Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong DPE and GES images #2

Open
Teddy-GFCOM opened this issue Sep 13, 2024 · 3 comments
Open

Wrong DPE and GES images #2

Teddy-GFCOM opened this issue Sep 13, 2024 · 3 comments

Comments

@Teddy-GFCOM
Copy link

Hello,

The DPE and GES images are wrong. A new standard issued in July 2021 in France and a revision have been done in 2024.
There are new calculation limits for DPE and GES as described below.

DPE

  • A : < 70
  • B : 71 to 110
  • C : 111 to 180
  • D : 181 to 250
  • E : 251 to 330
  • F : 331 to 420
  • G : > 421

GES

  • A : < 6
  • B : 7 to 11
  • C : 12 to 30
  • D : 31 to 50
  • E : 51 to 70
  • F : 71 to 100
  • G : > 101

I've found a library that should do the trick, and help migrate from the old to the new version : here

Hope this helps

@Teddy-GFCOM
Copy link
Author

I've done a basic implementation of the library on the plugin that work for me : I've only imported function and merged both classes in a single file. The code is dirty but it works ! :)

In order not to bother translating and positioning the texts, I edited every base pictures to put texts. This is not suitable for a multi-lang website but for me its perfect.

I can provide the code if needed for help.

Regards

@ilhooq
Copy link
Member

ilhooq commented Sep 16, 2024

I can provide the code if needed for help.

Hi Teddy, sure. You can even open a pull request to add your code to this project.

@Teddy-GFCOM
Copy link
Author

Sure !
However, I saw that i used the 2.4 version of the plugin to implement code...
I will need some time to merge it.
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants