Remove deprecated functions #1193
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronosapiens
force-pushed
the
maint/deprecation-removal
branch
5 times, most recently
from
674adf8
to
f2a8604
Compare
area
commented
Oct 15, 2024
.storage-layouts-normalized/contracts/colony/Colony.sol:Colony.json
Outdated
Show resolved
Hide resolved
kronosapiens
force-pushed
the
maint/deprecation-removal
branch
from
440ccc6
to
639ffe5
Compare
kronosapiens
force-pushed
the
maint/deprecation-removal
branch
from
639ffe5
to
74127f8
Compare
kronosapiens
added
ready-for-review
in-progress
and removed
in-progress
ready-for-review
labels
kronosapiens
force-pushed
the
maint/deprecation-removal
branch
from
16cb5de
to
373c610
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while, we've been marking functions as deprecated, and not doing anything further.
The crows have come home to roost.
Ready for review, I reckon, but not to merge - both because of the upcoming release, and because this will need testing against the dapp and the cdapp to make sure they're not using anything that we're removing, and then having those updated accordingly.