Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed usage of code as identifier. #1100

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nishant-sachdeva
Copy link

@nishant-sachdeva nishant-sachdeva commented Oct 26, 2022

We're currently implementing immutable for dynamic types in the compiler. With things like arrays and structs, however, it's much more tedious to enforce the immutability at contract construction time (and not everyone even thinks that this immutability is desirable) so we decided to make them freely writable at that stage instead. To make this clear we're introducing a new keyword: code. This is a breaking change so it will only really become a keyword in 0.9.0.

Turns out that colonyNetwork has one instance of code being used as an identifier. This PR changes its name for future compatibility and also will help us test the compiler against colonyNetwork without having to maintain a fork just for this small tweak.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kronosapiens
Copy link
Member

@nishant-sachdeva thanks for letting us know! Can you sign the CLA so we can move forward with the review?

@kronosapiens
Copy link
Member

Making a note to check with front-end about whether they reference the code variable by name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants