Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Expenditures] bug: all of voting reputation motions to fund an expenditure use the root domain to check for permissions #3705

Open
bassgeta opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@bassgeta
Copy link
Contributor

This is something I have discovered while rummaging around the codebase, but given these few lines
image

Makes it apparent that we always check for permissions in the root domain.
Why does this work? Well because we have another bug that always creates an expenditure in the root domain, so this works by chance 🫠

How to solve it

We need to create expenditures in the domain we are funding it from and then we need to realign the funding motion to get the action domain and get all the skill indices accordingly.

TBD: needs more info, if something is amiss, just ping @bassgeta

@bassgeta bassgeta added the bug Something isn't working label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant