Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Recent" commit broke an existing feature / is project still being actively maintained? #188

Open
wjtk4444 opened this issue Jan 17, 2022 · 1 comment

Comments

@wjtk4444
Copy link

Changes in voice.js/initVoice and it's surroundings in 506a799 seem to be the cause of #159.

@Johni0702 are you accepting PRs? I'm not a node expert by any means but this looks like a simple enough fix to give it a shot in case you don't have the time anymore to work on this project. Asking mainly because I see #181 being open and inactive for half a year now. As an everyday user I think mumble-web is feature-complete, but these 2 issues - blocking userMedia error and no disconnect button - are particularly annoying to deal with and definitely could use some attention.

@Johni0702
Copy link
Owner

If it's fairly straight forward, then yes.
The thing which caused the disconnect PR to indefinitely end up on my "will deal with it later" pile is the uncertainty about the license of the icon which it adds. It wasn't made by the PR author, so I cannot assume it to be available under the same license as mumble-web and and I couldn't easily find the license on the pages they linked either (but there must be something special about them if they felt the need to explicitly add attribution for them to the README). And just typing this took longer than I'm generally willing to spend on anything JS related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants