Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing Basic Auth from config file fails when password has a pound sign # in it. #195

Closed
cathelijne opened this issue Jun 29, 2021 · 1 comment

Comments

@cathelijne
Copy link

This is an exact copy of #194 that I submitted with the wrong username:

I have something like this in my configuration file:

login = user:pass:realm
login = [email protected]:password_with_#_in_it:realm 2

Siege -C output:

CURRENT  SIEGE  CONFIGURATION
Mozilla/5.0 (pc-x86_64-linux-gnu) Siege/4.0.9
Edit the resource file to change the settings.
----------------------------------------------
version:                        4.0.9
      [removed for clarity]
www auth:                       credentials:  user:pass:realm
credentials:  [email protected]:password_with_:any

Whatever I try (quoting the whole string, quoting only the password, escaping, urlencoding, trying to put the pass in a var and using that as suggested for the url file in this issue: #189), I cannot make siege understand that the line shouldn't be cut off after the pound sign. Is this just a feature of the parser, or have I overlooked something?

_Including Jeffs answer to #194 _

This looks right: @.***:password_with_#_in_it:realm 2 However, I think you encountered a bug. It's treating the password like a comment. I'll try to provide a fix soon.

@JoeDog
Copy link
Owner

JoeDog commented Jul 4, 2021

This issue was fixed with version 4.1.0 which is in the repo.

@JoeDog JoeDog closed this as completed Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants