Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show active build status in readme #490

Open
nojaf opened this issue Mar 4, 2023 · 5 comments
Open

Show active build status in readme #490

nojaf opened this issue Mar 4, 2023 · 5 comments

Comments

@nojaf
Copy link
Contributor

nojaf commented Mar 4, 2023

Hello,

I just synced my fork and can no longer build my ReSharper.FSharp.sln.

See errors
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\AnonModulePart.cs(8,18):
 error CS0534: 'AnonModulePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypeP
arameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\EnumPart.cs(9,18): error
 CS0534: 'EnumPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypeParameter(int
)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\DelegatePart.cs(18,18):
error CS0534: 'DelegatePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypePara
meter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\ClassPart.cs(12,18): err
or CS0534: 'ClassPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypeParameter(
int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\ExceptionPart.cs(15,18):
 error CS0534: 'ExceptionPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypePa
rameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\DeclaredElement\FSharpTypeParameterOf
Method.cs(18,75): error CS0535: 'FSharpTypeParameterOfMethod' does not implement interface member 'ITypeParameter.Nulla
bleAnnotation' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\HiddenTypePart.cs(12,18)
: error CS0534: 'HiddenTypePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForType
Parameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\InterfacePart.cs(8,18):
error CS0534: 'InterfacePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypePar
ameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\NestedModulePart.cs(7,18
): error CS0534: 'NestedModulePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForT
ypeParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\NamedModulePart.cs(7,18)
: error CS0534: 'NamedModulePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTyp
eParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\ObjectExpressionTypePart
.cs(13,16): error CS0534: 'ObjectExpressionTypePart' does not implement inherited abstract member 'TypePart.IsNullableC
ontextEnabledForTypeParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Ps
i.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\RecordPart.cs(15,18): er
ror CS0534: 'RecordPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypeParamete
r(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\RecordPart.cs(33,18): er
ror CS0534: 'StructRecordPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypePa
rameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\StructPart.cs(8,18): err
or CS0534: 'StructPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypeParameter
(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\TypeExtensionParts.cs(11
,18): error CS0534: 'ClassExtensionPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnable
dForTypeParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\TypeExtensionParts.cs(32
,18): error CS0534: 'StructExtensionPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabl
edForTypeParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\TypeAbbreviationOrDeclar
ationPart.cs(10,18): error CS0534: 'TypeAbbreviationOrDeclarationPart' does not implement inherited abstract member 'Ty
pePart.IsNullableContextEnabledForTypeParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FS
harp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\TypeAbbreviationOrDeclar
ationPart.cs(26,18): error CS0534: 'StructTypeAbbreviationOrDeclarationPart' does not implement inherited abstract memb
er 'TypePart.IsNullableContextEnabledForTypeParameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\
src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\UnionPart.cs(31,18): err
or CS0534: 'StructUnionPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypePara
meter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\UnionCasePart.cs(12,18):
 error CS0534: 'UnionCasePart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypePa
rameter(int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\src\Impl\Cache2\Parts\UnionPart.cs(13,18): err
or CS0534: 'UnionPart' does not implement inherited abstract member 'TypePart.IsNullableContextEnabledForTypeParameter(
int)' [C:\Users\nojaf\Projects\resharper-fsharp\ReSharper.FSharp\src\FSharp.Psi\FSharp.Psi.csproj]
    393 Warning(s)
    21 Error(s)

This could mean two things:

  • There is an actual problem with the net231 branch here.
  • Something locally isn't working out due to some caching.

It would be great if I could go to the home page of this repository and see if the current branch is indeed building correctly.
I guess some workflow very similar to .github\workflows\ci.yml would suffice where the code is built every time there is a commit. (Maybe skip running the tests, I don't know about that).
Once this is set up a badge could be displayed from https://shields.io/category/build in the ReadMe.

Does this sound sensible?

@auduchinok
Copy link
Collaborator

@DedSec256 Could you look into that when you have time, please?

@auduchinok
Copy link
Collaborator

@nojaf Sorry for the broken build, we usually tend to fix things quickly after API changes, but this time it happened on a Saturday night, so I haven't seen it was failing yet.

I've fixed it in be904f8, please try to build it again.

@nojaf
Copy link
Contributor Author

nojaf commented Mar 4, 2023

Thanks @auduchinok I'm able to build now locally!

@DedSec256
Copy link
Contributor

I'll take a look. However, we have an external dependency on a daily SDK build, so the current CI will not help track down API breakdowns, and we need to figure out how to trigger the build every day, regardless of commits to the main branch.

@nojaf
Copy link
Contributor Author

nojaf commented Mar 6, 2023

You can do cron stuff in GitHub actions if I remember correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants