Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 - migration plugin should say if something is wrong #1630

Open
jonathanlermitage opened this issue May 21, 2024 · 7 comments
Open

2.0 - migration plugin should say if something is wrong #1630

jonathanlermitage opened this issue May 21, 2024 · 7 comments

Comments

@jonathanlermitage
Copy link

jonathanlermitage commented May 21, 2024

Describe the need of your request

Using plugin id("org.jetbrains.intellij.platform.migration") version "2.0.0-beta3"
It always says:

As soon as you'll handle all configuration problems, remember to remove this plugin from your plugins {} block and eventually rename the intellij {} extension to intellijPlatform {}.
Note: We encourage avoiding configuring tasks directly, like: patchPluginXml { ... }, publishPlugin { ... }, signPlugin { ... }, ...
Use the intellijPlatform { } extension instead:
...

But it doesn't say what's wrong with my build.

Proposed solution

The migration plugin should enumerate what's wrong or, if everything is okay, it should say it found no issue.

Alternatives you've considered

No response

Additional context

I am not using publishPlugin and signPlugin, only patchPluginXml. For this last one, I found no documentation about this. We have documentation for plugin v1 https://plugins.jetbrains.com/docs/intellij/tools-gradle-intellij-plugin.html#tasks-patchpluginxml, but how to migrate patchPluginXml to plugin v2 (if needed, I have no idea)? I can package my plugin with success. I guess the migration plugin simply found no issue, but I'm not sure.

@jonathanlermitage jonathanlermitage changed the title migration plugin should say if something is wrong plugin v2: migration plugin should say if something is wrong May 21, 2024
@jonathanlermitage jonathanlermitage changed the title plugin v2: migration plugin should say if something is wrong 2.0: migration plugin should say if something is wrong May 21, 2024
@jonathanlermitage jonathanlermitage changed the title 2.0: migration plugin should say if something is wrong 2.0 - migration plugin should say if something is wrong May 21, 2024
@YannCebron
Copy link
Member

That text is just a general warning. Indeed, it should list/highlight deprecated properties and problems from your 1.x build file.

Not quite sure what the problem is without an actual sample and expected vs actual.

@tim-sh
Copy link

tim-sh commented Jun 10, 2024

As far as I'm concerned, just use any IJ plugin built with IntelliJ Platform Gradle Plugin 1 and try to use org.jetbrains.intellij.platform.migration (add to or replace existing plugin reference org.jetbrains.intellij.platform) in build.gradle.
Build errors continue to happen one by one during gradle buildPlugin, and the migration plugin does not give any hints in the IDE.

@tim-sh
Copy link

tim-sh commented Jun 20, 2024

@YannCebron Any hints on how to get this migration plugin to get to work would be appreciated.

@tim-sh
Copy link

tim-sh commented Aug 14, 2024

@YannCebron Can you reproduce this with my hints? The issue blocks me from migrating, please support.

@tim-sh
Copy link

tim-sh commented Aug 15, 2024

If it helps, I'll provide a sample @hsz

@hsz
Copy link
Member

hsz commented Aug 15, 2024

Please provide all logs, and your setup so I could verify what exactly issues you face.

@tim-sh
Copy link

tim-sh commented Aug 29, 2024

@hsz In a new trial, I was able to figure out all necessary changes without using the migration plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants