Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): re-run meson setup if it failed #42

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix(build): re-run meson setup if it failed #42

merged 1 commit into from
Dec 7, 2023

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Dec 7, 2023

The generated install-iguana.sh script was not re-running the meson setup step if it failed e.g., due to a missing dependency. This PR sets it to run meson setup always.

When a successfully configured buildsystem exists, meson setup will just let the user know, and even prints a helpful run "meson setup --wipe" message for the user. IIRC, older versions of meson would instead throw an error message, but we require a modern version here anyway.

@c-dilks c-dilks enabled auto-merge (squash) December 7, 2023 00:45
@c-dilks c-dilks merged commit f3b0ab5 into main Dec 7, 2023
7 checks passed
@c-dilks c-dilks deleted the fix-setup branch December 7, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant