New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove `ThreadPoolParam` #281

Merged

c-dilks merged 1 commit into threadpool from rm-threadpoolparam

Sep 25, 2024

Member

c-dilks commented Sep 25, 2024 •

edited

Loading

See discussion and benchmarks in #258. In summary,

ThreadPoolParam is only sometimes better than MemoizedParam, but in some cases, can be significantly worse
Addition of thread_id parameter to Algorithm::Run and reload-type action functions reduces user-friendliness of those functions


          refactor!: remove ThreadPoolParam

285bf96

c-dilks force-pushed the rm-threadpoolparam branch from 289adee to 285bf96 Compare

September 25, 2024 15:15

c-dilks marked this pull request as ready for review

September 25, 2024 15:24

c-dilks requested review from Gregtom3 and rtysonCLAS12 as code owners

September 25, 2024 15:24

c-dilks merged commit 43096f6 into threadpool

44 of 45 checks passed

c-dilks deleted the rm-threadpoolparam branch

September 25, 2024 15:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet