Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat+build: improve algorithm configuration; colored log output; improve dependency resolution #20

Merged
merged 34 commits into from
Nov 29, 2023
Merged

feat+build: improve algorithm configuration; colored log output; improve dependency resolution #20

merged 34 commits into from
Nov 29, 2023

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Nov 22, 2023 •
edited
Loading

The scope of this PR expanded beyond its original intent, and should actually separated into the following PRs:

feat: configuration streamlining

  • cache the option to avoid hashing in Run
  • set default option values
  • provide SetOption for the user
  • provide PrintOption to dump options

feat: colored log output

  • error and warn log printouts are now colored
  • enabled by default, and can be disabled by the user

build: improved dependency resolution

  • use built-in options for better user control

c-dilks
c-dilks commented Nov 25, 2023
View reviewed changes
src/services/Algorithm.h Outdated Show resolved Hide resolved
@c-dilks
refactor: try to typecast bad options, or fallback to default
f03109a
@c-dilks
fix: don't typecast, just complain
2a377e2
@c-dilks
test: int and double types
b49a6bd
@c-dilks
feat: user set algorithm log level
4135753
@c-dilks
feat: colored errors and warnings
3121cef
@c-dilks
fix(ci): use a newer fmt
e5663a9
@c-dilks
fix: use realpath for fmt
2808ba2
@c-dilks
fix: cmake method for hipo4
7b3751c
@c-dilks
test: syntax
70e5816
@c-dilks
fix: use fixed hipo version
29fa71a
@c-dilks
test: tree
ec2b59e
@c-dilks
test: find hipo first
a82692a
@c-dilks
test: combined cmake prefix path
fe76bf3
@c-dilks
fix: var name
6aaa781
@c-dilks
fix: another var name
879e3eb
@c-dilks
test: build fmt shared library setting
bf8104e
@c-dilks
test: build fmt static lib
e01c249
@c-dilks
test: TRUE -> ON
558712c
@c-dilks
fix: barking up the wrong tree
a42653e
@c-dilks
build: use pkg-config for fmt
e1917be
@c-dilks
fix: full path to pc file
f2df416
@c-dilks
build: use cmake_prefix_path builtin
cfd3c5c
@c-dilks
fix: build hipo with -fPIC
803fbb7
@c-dilks
fix: include hipo in rpath
0475a90
@c-dilks
deleted: meson.options
8522ef1
@c-dilks
refactor: generate native ini file
6960e15
@c-dilks c-dilks changed the title feat: streamline configuration option setting feat+build: streamline configuration option setting and dependency resolution Nov 29, 2023
@c-dilks c-dilks changed the title feat+build: streamline configuration option setting and dependency resolution feat+build: improve algorithm configuration; colored log output; improve dependency resolution Nov 29, 2023
@c-dilks c-dilks marked this pull request as ready for review November 29, 2023 19:57
@c-dilks c-dilks merged commit 0b62279 into main Nov 29, 2023
5 checks passed
@c-dilks c-dilks deleted the config-refactor branch November 29, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@c-dilks