Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate synchronous AylaApi methods #10

Open
travipross opened this issue Apr 7, 2022 · 2 comments
Open

Deprecate synchronous AylaApi methods #10

travipross opened this issue Apr 7, 2022 · 2 comments

Comments

@travipross
Copy link
Contributor

A number of requests-based methods in sharkiq.ayla_api.AylaApi are synchronous and most likely unused. These should be removed to consolidate all web request logic into a set of async methods.

More discussion in #4
@funkybunch
Copy link
Collaborator

@travipross if you're not tired of looking at the Ayla API yet, this refresh token (#5) is a real pain that we haven't had a chance to address yet. If you have time we'd love some help with that one as well.

@travipross
Copy link
Contributor Author

@funkybunch I'd be happy to give it a shot, but I've not quite wrapped my head around the issue just yet. I find the hard part is actually reproducing the issue to test against it.

If I can find the time and inspiration, I'll do my best to take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@funkybunch @travipross