-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package name remapping functionality #56
Comments
Hello, great idea. |
Hi @MrLixm !
Can you clarify what you mean by this? I'm not too sure to understand the use case or the problem you are solving with add a suffix to versions. |
Ha sorry, in the case you need to re-release a version that has already been released. |
I would prefer if users change the version in the forked package itself. The python ecosystem even has a system to handle this kind of scenario called local version identifiers. rez-pip (the original) and rez-pip2 (this repo) both already know how to handle this. |
Alright, I have a little bit more time to expand on my last reply. In the workflow you explained, you take an open source project, fork it and do some changes. If you are doing modifications, then you probably want to track these changes in some ways. So while being there, you can also add a little There is another aspect to take into consideration too. This new rez-pip doesn't have the ability to build wheels. It can only install wheels. So unless you manually download wheels, unpack them and modify them to then re-pack them, or fork projects and manually build wheels from source. So all in all, I don't think it's a good idea to add a version suffix functionality. At least not with the use case you provided. Please let me know if I misinterpreted what you said. |
It does make sense, I'm still trying to figure out the workflow you mentioned when needing to patch a software. With that I don't have any more argument in favor of opening the versioning right now. I let you know if I find any during my investigation 😛 |
In relation to #55, it would be handy to have a way to control the names of the packages that we create. This would probably be a mapping/dict either defined through a CLI, or a config setting.
We might also need a way to automatically prefix all package names?
The text was updated successfully, but these errors were encountered: