Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Humble] Duplicate worlds in the repository #337

Open
pawanw17 opened this issue Oct 11, 2023 · 9 comments
Open

[Humble] Duplicate worlds in the repository #337

pawanw17 opened this issue Oct 11, 2023 · 9 comments

Comments

@pawanw17
Copy link
Collaborator

There exist duplicate worlds inside Worlds directory and CustomRobots/

  • roomba_robot/worlds
  • ackermann_cars/worlds
  • car_junction/worlds
  • amazon_robot/worlds
  • amazon_hospital/worlds
  • autoparking/worlds
@Tanishq30052002
Copy link

Hi @pawanw17 ,
I would like to work on the issue, can i go ahead with it?

@pawanw17
Copy link
Collaborator Author

Sure please

@Tanishq30052002
Copy link

hey @pawanw17 ,
In the repo there are different worlds files and different launch files too, so am I supposed to convert them to launch.py format too so it will be compatible with ROS2 also. Also, many more pkgs have the same problem, so could you please clarify it?

@pawanw17
Copy link
Collaborator Author

Hi @Tanishq30052002, In this repo mainly we have two branches which are actively developed,
noetic-devel and humble-devel, inside these you can find .world files which gazebo uses, This issue is only targetting the world files and not the launch files.

@Tanishq30052002
Copy link

Tanishq30052002 commented Mar 16, 2024

Hi @pawanw17
Should I add different world files too in world directory?

@pawanw17
Copy link
Collaborator Author

What do you mean?

@Tanishq30052002
Copy link

@pawanw17
Since in custom robots there are some more world files which are not duplicate to the ones in the world directory.
So I want to know if we are supposed to move those world files to the world directory also?

@pawanw17
Copy link
Collaborator Author

@jmplaza where should we keep all the world files? inside CustomRobots folder?

That way when CustomRobots is built they would automatically be sourced, but I don't know if other applications(Visualcircuit, btstudio) build CustomRobots.

@Tanishq30052002
Copy link

hi @pawanw17 @jmplaza
I would be glad if you could please clear the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants