-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement suggestions for BDD Flutter blog #150
Comments
Additionally, the following changes related to writing style and understandability have been suggested in #147 https://github.com/JankariTech/blog/pull/147/files#r1658213438 |
Creating a separate issue for the PR comments is not a good idea. It's better to add and resolve the suggestions in PR itself. |
it was suggested by @individual-it to separate fixing content and improving writing style and understandability :) |
The original PR should be about fixing issues in the blog that make it be not-up-to-date e.g. code or outdated links. In my opinion this is a separate work, as it is about the general writing style etc. |
Then I don't have to address suggestions in PR #147. |
I guess for traceability it's better to separate, but I think you already started implementing some of these suggestions, so don't delete the work you've already done! Would it be easy to copy what you have already done into another PR? |
while most of the points above have already been addressed in PR #147, here are a few more things regarding clarity and readability that came up when reviewing #147
|
Here are some points, mainly related to English language and grammar, readability and understandability, that I noticed when reviewing the PR for BDD Flutter blog updates.
flutter pub get
.” or add this sentence fragment to the previous sentence in line 68Originally posted by @koebel in #147 (review)
The text was updated successfully, but these errors were encountered: