Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the actual values of gathered data when testing/debugging #86

Open
LukasKnuth opened this issue Jan 28, 2013 · 4 comments
Open

Show the actual values of gathered data when testing/debugging #86

LukasKnuth opened this issue Jan 28, 2013 · 4 comments

Comments

@LukasKnuth
Copy link

Currently, when using --test or --debug, we don't see the actual values of the "Gathering data"-section, but only debugging things:

RESULT:DTSLANG=DTSLANG

I think it makes more sense to execute the "Gathering Data"-section (and only it) as you normally would and print the actual values.

Collecting information doesn't change the source-file.

@choekstr
Copy link
Collaborator

Yeah, I see a bug where someone misplaced the quotes:
DTSLANG=$"DTSLANG" #Value for debugging
should be:
DTSLANG="$DTSLANG" #Value for debugging

The intention is to show the value of DTSLANG as you wish and one would expect. Merely a typo that can be fixed easily to return this to normal working order.

@LukasKnuth
Copy link
Author

It seems you're wrong:

DTSLANG="$DTSLANG" #Value for debugging
dopause
if [ $EXECUTE = 1 ]; then
    DTSLANG=$(echo "$INFO" | grep -m 1 "Language" | cut -d " " -f 5)
    if [ -z "$DTSLANG" ]; then
        DTSLANG=$"eng"
    fi
fi
doprint "RESULT:DTSLANG=$DTSLANG"

The real population of the $DTSLANG is never done when --test is used, because $EXECUTE is set to 0 in this case.

@1951FDG
Copy link

1951FDG commented Jan 28, 2013

The population of $DTSTRACK, $VALID, $INFO, $DTSLANG, $DTSNAME & $DELAY is only done when --debug is used, because $EXECUTE is set to 1 in this case.

LukasKnuth is suggesting to execute the "GATHER DATA"-section (and only it) when $PRINT is set to 1. The population of $DTSTRACK, $VALID, $INFO, $DTSLANG & $DTSNAME will then be done when --test or --debug is used.

@1951FDG
Copy link

1951FDG commented Jan 29, 2013

Opened pull request (#87)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants