Fix: Provide timeouts for reading from sockets #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Microsoft's CDNs are having a bad day, or when a user has limited bandwidth, the download process can stall and die permanently. This change allows xwin to recognise when this has happened and do something about it.
|
Sorry it took so long to get to this, I've changed it a little bit so that the user can specify the timeout value via the cmd line to avoid hardcoding, but set 60s to the default instead of infinite as 60s should be more than enough. |
Jake-Shadle
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Microsoft's CDNs are having a bad day, or when a user has limited bandwidth, the download process can stall and die permanently.
This PR allows xwin to recognise when this has happened and do something about it. Currently that's to fail gracefully, allowing the user to retry.