Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #109 and #104 (and #50) I've decided to change the structure of Ctx to force users to pass in their own
ureq::Agent
that is configured how they want it to be, rather than adding more and more customization into the library itself.xwin
was never intended as a library, but since people are using it that way, I don't think it's a good idea to have the HTTP client customization in the library, especially since it's reading environment variables which IMO is not something libraries should do in most cases. This is a bit unfortunate since it means callers have to have their own code if they want to customize, but it means this crate is simpler, and caller's are free to make whatever decisions they want (other than HTTP client, but that's something that can be done later).