-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add location nicknames #242
Comments
@JacobEvelyn I'd like to work on this issue and raise a PR for this soon |
Perfect, @v4vasanth ! Let me know how I can best assist you! |
@v4vasanth anything I can do to help? |
@v4vasanth are you still interested in this or should I assign it to someone else? |
Hi i would like to work on this. Additional to that i found a small missing documentation in the |
Thanks, @RenCloud! I’ll assign this issue to you. And I think having another PR to fix the documentation would work best for me. Thank for picking these up, and please let me know if there’s anything I can do to help! |
Okay, great. I have started the implementation, but I have some open questions. The first question is how to name the command. Currently I'm adding two new commands: Additionally I have a question about the method While writing I thought about your request/idea with the duplicate. The current system does not allow duplicate names or locations, but it does for nicknames. (After that the matching might not be as correct, but it works.) Maybe I'm missing something at |
Hey @RenCloud! So glad to hear you've started working on this and thanks for the great questions!
This is a great question, and one I hadn't actually thought deeply about. In the past I've tended to use nested commands (such as multiple
Of these I'm leaning toward either 1 or 4. What do you think?
Great question! While it's possible we'd want that someday, I think for now just matching only direct matches as you've done is perfect. The complex five-step algorithm is really just to handle the ambiguities of many people sharing the same name, which I think is infrequent enough for locations that we can ignore for now.
Ha, honestly I don't remember what I was imagining here. I think the way you're approaching it is fine, and actually I would prefer to not have two locations with the same nickname either. With the Portland scenario I think nicknames would at least allow something like adding |
I'm glad to help.
I also think that option 2 and 3 are not so great. Especially because they add another layer to the command, making it very long. For the sake of simplicity I think the 4th option is better. It's not quite as descriptive, but it fits better with the other one. The combination of 2 words with underscore does not fit the simple call of the other commands.
That was what I thought. Besides helping to find the right location, supporting nested locations is probably the better choice.
If I understood correctly that you are currently entering the two But in this case, that doesn't account for the problem I had in mind.
I thought so too. But at the moment I have added it very similar to the 'friend nickname', and there it is possible. However, I will not allow it for place names then. |
Cool,
Completely agree! Looking forward to when #246 is done! 😄
Ah yes, I wasn't clear—sorry! I was imagining this as the locations were named
Yeah it's definitely a bit confusing, but I think it's okay for friends to share the same nickname because of that five-step algorithm for deciding which friend is being referenced. (Just as I might have three friends named "Jacob," they might all also go by "Jake.") But for locations since we're just doing a strict match I think it'll be confusing to allow duplicates for now. Thanks so much for working on this and let me know if you have any questions! ❤️ |
Thanks so much for all the hard work here, @RenCloud! I've just merged this and released it in v0.54. You can get it with Congratulations on becoming an official contributor, and I'd love to have you contribute again in the future! |
Commands and behavior should be pretty much the same as friend nicknames. Would be really useful, especially with multiword locations (
New York City
could be nicknamed asNYC
) and "duplicate" nicknames (Portland, OR
andPortland, ME
).The text was updated successfully, but these errors were encountered: