Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VALSO-VALTRANS and VALNA should be merged #6

Open
DaveStorkey opened this issue Aug 19, 2024 · 0 comments
Open

VALSO-VALTRANS and VALNA should be merged #6

DaveStorkey opened this issue Aug 19, 2024 · 0 comments

Comments

@DaveStorkey
Copy link
Collaborator

The reason that there are separate VALSO-VALTRANS and VALNA directories under Marine_Val is purely historical (they were developed by different people at different times) and they should be merged. The high level code (and a lot of the low level code) is the same and it is inefficient to have duplicate copies of things. For example, I have improved the data retrieval scripts for VALSO-VALTRANS, but these changes haven't gone into the VALNA versions.

The procedure for merging would be to try to reproduce the standard VALNA plots within VALSO-VALTRANS by copying the relevant scripts over. Once this was achieved, the contents of VALSO-VALTRANS could be moved up a level and the VALSO-VALTRANS directory deleted. The VALNA directory could be kept for a while; I think there are some "optional extras" that Sophia made that we should keep. The README.md file would need to be updated of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant