forked from spack/spack
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release/1.8.0 into spack-stack-dev #478
Merged
climbfuji
merged 10 commits into
JCSDA:spack-stack-dev
from
climbfuji:feature/merge_rel180_into_spackstackdev
Oct 3, 2024
Merged
Merge release/1.8.0 into spack-stack-dev #478
climbfuji
merged 10 commits into
JCSDA:spack-stack-dev
from
climbfuji:feature/merge_rel180_into_spackstackdev
Oct 3, 2024
+38
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc@:5 hits https://savannah.gnu.org/bugs/index.php?65811 in [email protected]: also fix patch of configure script Co-authored-by: Harmen Stoppels <[email protected]>
Fix gettext patch
Fix grib-util 1.4.0 for older ifort
…ck#477) Bug fix for compiling [email protected] with gfortran < 10 --------- Co-authored-by: RatkoVasic-NOAA <[email protected]>
This PR adds in the necessary configuration to get the latest MacOS and Command Line Tools versions working (14.6.1 and 15.3 respectively). This PR includes a patch for FMS 2024.02 and a variant spec that builds shared (dylib) libraries. This makes it unnecessary to do the manual FMS build workaround that was recently published. The FMS patch is only needed for version 2024.02 in that the next version (2024.03) contains the update to the CMakeLists.txt file that adds in the shared library option. --------- Co-authored-by: Dom Heinzeller <[email protected]>
This was referenced Oct 3, 2024
climbfuji
requested review from
AlexanderRichert-NOAA,
srherbener and
RatkoVasic-NOAA
October 3, 2024 14:26
RatkoVasic-NOAA
approved these changes
Oct 3, 2024
AlexanderRichert-NOAA
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All in the title. For testing, see CI tests below and JCSDA/spack-stack#1321.
Note that some of the CI tests for spack itself are failing (see below and https://github.com/JCSDA/spack/actions/runs/11155057001?pr=478). However, these seem to be unrelated to this PR, since I see the same problems when I run the CI spack tests for
spack-stack-dev
(https://github.com/JCSDA/spack/actions/runs/11161442545/job/31029164908). Maybe this needs an update from spack develop to work properly?