revert jcsda modifications to lib/.../modules/* #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
…py-shapely/shapely-1.8.0-geos.py.patch
…hert-noaa/spack into feature/geos_root_shapely_uppercase
|
@AlexanderRichert-NOAA I updated your branch from jcsda_emc_spack_stack. I also created a PR that you will need to merge/pull in so that this reversal of the lowercase |
Replace geos_ROOT with GEOS_ROOT in var/spack/repos/builtin/packages/py-shapely/shapely-1.8.0-geos.py.patch
climbfuji
approved these changes
Mar 5, 2024
|
Note that this also requires changes in GEOS-GCM, see GEOS-ESM/GEOSgcm#767 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove our customizations to Spack's module logic. See JCSDA/spack-stack#972 for details & discussion.
Checklist