Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for MAPL, GFE packages in spack #641

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jun 22, 2023

Description

Currently, this PR only updates the submodule pointer for spack to include and test the updates from JCSDA/spack#241. No version changes as part of this PR.

Issue(s) addressed

@mathomp4 Do you know if this update resolves any of the open issues in spack-stack?

Dependencies

List the other PRs that this PR is dependent on:

Impact

Expected impact on downstream repositories: possibly JEDI and UFS - need to test

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@climbfuji climbfuji marked this pull request as ready for review June 22, 2023 21:39
@climbfuji climbfuji self-assigned this Jun 22, 2023
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Jun 22, 2023
@climbfuji
Copy link
Collaborator Author

@mathomp4 The CI tests passed, which means that the changes to the mapl package (build updates) didn't break anything. I haven't changed any of the versions in this PR. This should be a follow-up change to expedite getting your spack PR in. For now, we should run a few basic tests with the updated mapl build (using the ufs-weather-model and/or ufs-srw-app?)

@mathomp4
Copy link
Collaborator

@mathomp4 The CI tests passed, which means that the changes to the mapl package (build updates) didn't break anything. I haven't changed any of the versions in this PR. This should be a follow-up change to expedite getting your spack PR in. For now, we should run a few basic tests with the updated mapl build (using the ufs-weather-model and/or ufs-srw-app?)

@climbfuji Yes. A test with UFS, etc would be a good idea. I did tweak some depends, but I think they all depend on (currently) default-false variants. The only possible issue might be ESMA_cmake as @AlexanderRichert-NOAA seems to hit it every so often.

But if things build and not crash...good sign. Even up to 2.39.3 here didn't do much to dependent libraries. MAPL 2.40 will change quite a bit as we advance many of the dependent library versions then (including an ESMF beta snapshot).

@climbfuji
Copy link
Collaborator Author

@AlexanderRichert-NOAA @mathomp4 This is good to go from my side (just the submodule pointer update). CI tests passed.

@climbfuji climbfuji merged commit 43bee67 into JCSDA:develop Jun 30, 2023
4 checks passed
@climbfuji climbfuji deleted the feature/gmao_gfe_updates branch June 30, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants