Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changes to 1.6.0 for machines that switched to Rocky OS #1312

Conversation

RatkoVasic-NOAA
Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA commented Sep 25, 2024

Summary

Since 1.6.0 release some machines switched to Rocky OS. Need to update config files for those machines.

Testing

Install from new branch

Applications affected

All

Systems affected

Hera, Orion, NOAA-cloud,... (will check for others)

Dependencies

No dependences

Issue(s) addressed

Closes issue #1316

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji
Copy link
Collaborator

I am removing myself as a reviewer - this is updating a non-month old release/branch that only NOAA still uses

@climbfuji climbfuji removed their request for review September 27, 2024 20:00
@RatkoVasic-NOAA RatkoVasic-NOAA self-assigned this Sep 27, 2024
@@ -1,15 +1,15 @@
mirrors:
local-source:
fetch:
url: file:///mnt/lfs4/HFIP/hfv3gfs/role.epic/spack-stack/source-cache
url: file:///contrib/spack-stack/source-cache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be safely reverted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I copied today everything from current mirror to that one.

access_pair:
- null
- null
access_token: null
profile: null
endpoint_url: null
push:
url: file:///mnt/lfs4/HFIP/hfv3gfs/role.epic/spack-stack/source-cache
url: file:///contrib/spack-stack/source-cache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" "

Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check the source cache path on Jet, but otherwise this looks good to me.

@AlexanderRichert-NOAA
Copy link
Collaborator

@RatkoVasic-NOAA if/when you're ready please bypass the branch protection settings and merge :)

@RatkoVasic-NOAA
Copy link
Collaborator Author

@RatkoVasic-NOAA if/when you're ready please bypass the branch protection settings and merge :)

I guess I have to wait for unit tests to finish first. How do I merge this branch (bypass protection)?

@AlexanderRichert-NOAA AlexanderRichert-NOAA merged commit ad8b191 into JCSDA:release/1.6.0 Oct 1, 2024
3 of 7 checks passed
@AlexanderRichert-NOAA
Copy link
Collaborator

Done. It might require admin privileges, I'm not sure.

@RatkoVasic-NOAA
Copy link
Collaborator Author

Done. It might require admin privileges, I'm not sure.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants