Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Configure neptune-env variants in three templates: neptune-dev, skylab-dev, unified-dev #1268

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Aug 22, 2024

Summary

This is a bug fix PR: Configure neptune-env variants in three templates: neptune-dev, skylab-dev, unified-dev. This commit must have gotten lost yesterday in #1265 - not sure how. Either way, this is how I tested it, so let's see if CI is happy with it as well.

Testing

@climbfuji's laptop (concretized neptune standalone and unified environments)

Applications affected

All

Systems affected

None

Dependencies

None

Issue(s) addressed

None (bug fix for #1265)

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji requested a review from eap August 22, 2024 20:15
@climbfuji climbfuji self-assigned this Aug 22, 2024
Copy link
Collaborator

@eap eap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@climbfuji climbfuji enabled auto-merge (squash) August 22, 2024 21:44
@climbfuji climbfuji merged commit 489665d into develop Aug 23, 2024
8 checks passed
@climbfuji climbfuji deleted the bugfix/configure_neptune_variants_in_templates branch August 23, 2024 00:26
DavidHuber-NOAA added a commit to DavidHuber-NOAA/spack-stack that referenced this pull request Aug 26, 2024
* jcsda/develop:
  Bump Python to 3.11.7 (JCSDA#1217)
  Add a clause in the cleanup to fix directory permissions (JCSDA#1273)
  Bug fix: configure neptune-env variants in three templates: neptune-dev, skylab-dev, unified-dev (JCSDA#1268)
  Update site configs for Atlantis, Narwhal, Nautilus (JCSDA#1266)
  Configuration for [email protected] and [email protected] (JCSDA#1240)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants