Updates for mapl/esmf in packages.yaml and modules*.yaml #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged the spack submodule PR, please update the hash to JCSDA/spack@338cca0 in the authoritative repo |
done |
climbfuji
approved these changes
Jul 2, 2024
| @@ -143,6 +145,8 @@ | |||
| # also: ... extdata2g segfault UFS? | |||
| version: ['2.40.3'] | |||
| variants: ~shared ~extdata2g ~pflogger | |||
| #version: ['2.46.2'] | |||
| #variants: +pflogger | |||
There was a problem hiding this comment.
We may want to retain the variants for 2.40.3 (~shared ~extdata2g ~pflogger), but since this is just a comment it won't hurt. We can do a test install with the variants in line 147 on one platform first, have the UFS developers test it, and then roll it out or correct as necessary.
|
I am getting impatient with this - will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
minor changes to backport mapl/esmf to release/1.6.0. please see accompanying pr in spack #446.
Testing
Describe the testing done for this PR.
Applications affected
List all known applications (UFS WM, JEDI, SRW, etc.) intentionally or unintentionally affected by this PR.
Systems affected
List all systems intentionally or unintentionally affected by this PR.
Dependencies
If there are PRs that need to be merged before or along with this one, please add "- [ ] waiting on LINK_TO_PR" for each of them
Issue(s) addressed
Link the issues addressed or resolved by this PR (use
Fixes #???for fully resolved issues)Checklist