Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project_charter/documentation, update util/check_package_config.py, remove upp from unified-dev #1022

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 8, 2024

Summary

  1. Update README.md, project_charter.md and documentation with new maintainers and install responsibilities
  2. Remove upp from ufs-srw-app-env virtual package and clean up unified-dev template
  3. Fix several bugs in util/check_package_config.py: import yaml from spack _vendored, catch non-existent variants, test on macOS
  4. Update util/ldd_check.py and documentation - this tool only works on Linux

Testing

Applications affected

UFS SRW App - check if standalone upp is really not required

Systems affected

None

Dependencies

None

Issue(s) addressed

Resolves #825
Resolves #898

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Mar 8, 2024
@climbfuji climbfuji added INFRA JEDI Infrastructure NOAA-EMC OAR-EPIC NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center labels Mar 8, 2024
@climbfuji climbfuji force-pushed the feature/update_check_package_config_and_remove_upp branch 2 times, most recently from 187d2f4 to ef5bbfa Compare March 8, 2024 04:09
@climbfuji climbfuji force-pushed the feature/update_check_package_config_and_remove_upp branch from ef5bbfa to abb3a4e Compare March 8, 2024 04:10
@climbfuji climbfuji force-pushed the feature/update_check_package_config_and_remove_upp branch 7 times, most recently from fd7472e to 6d3c791 Compare March 8, 2024 14:41
@climbfuji climbfuji force-pushed the feature/update_check_package_config_and_remove_upp branch from 6d3c791 to 2ae50c5 Compare March 8, 2024 14:46
util/util_tests.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator

@ulmononian ulmononian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

@climbfuji climbfuji merged commit 0fae4bd into JCSDA:develop Mar 11, 2024
7 checks passed
@climbfuji climbfuji deleted the feature/update_check_package_config_and_remove_upp branch March 11, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure NOAA-EMC OAR-EPIC NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center
Projects
No open projects
4 participants