-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INSTALL]: install ESMF 8.6.1 and MAPL 2.46.2 in spack-stack 1.6.0 #1168
Comments
We need to do #1157 first, then this. |
#1157 was merged, so we can go ahead with this. Unlikely it will happen before the 4th of July weekend. Many people will be on leave. |
Below are the instructions and a list of platforms / assigned spack-stack installers: Instructions
with
in the List of platforms / installersONLY TICK IF YOU'VE ALSO FIXED THE GRIB-UTILS MODULE FOR WGRIB ONLY DO THIS FOR THE BASE UNIFIED-ENV - IGNORE THE ADDON ENVS
|
@climbfuji @AlexanderRichert-NOAA @jkbk2004 @junwang-noaa i installed a chained env based on 1.6.0 but with esmf/8.6.1 and mapl/2.46.2 here |
I am doing the |
@mathomp4 mapl 2.46.2 refuses to build on Hercules with gcc, because the 1.6.0 stack uses mvapich2:
Any quick fix for this (locally if needed - we've moved away from mvapich2 since spack-stack-1.7.0)? |
JCSDA/spack#449 and #1189 fix this for release/1.6.0, spack/spack#45164 for spack develop (it will come back to spack-stack-dev with the next pull). #1189 also fixes the missing |
@ulmononian Hercules is done for gcc, and I also fixed the |
@climbfuji thanks for taking on the hercules |
Correct. |
It looks like that the platforms missing are all EMC and EPIC systems - everything else is either done or not needed. |
In case it has not been reported here yet, I wanted to make aware this issue seen on Hercules when testing with the esmf/8.6.1 spack-stack 1.6.0 installation. @jkbk2004 @BrianCurtis-NOAA @FernandoAndrade-NOAA CMake Error at /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/ue-esmf-8.6.1-mapl-2.46.2/install/intel/2021.9.0/mapl-2.46.2-uiwt3at/lib64/cmake/MAPL/MAPL-targets.cmake:73 (set_target_properties):
but the target was not found. Possible reasons include:
|
That is so odd. I mean, ESMF 8.6.1 and MAPL 2.46 were essentially created to allow for the Hmm. My only next thought is that a Could you some how be picking up another one? It was noted by @danrosen25 in the ESMF PR, that, at the time these CMake files were out-of-date:
And a look at them shows them still quite old. Perhaps some package is still referring to an old |
I'm running with the MAPL FindESMF.cmake on WCOSS2 right now, but if this is the case, we should look into coordinating a place for one FindESMF.cmake to exist and other groups pull from that location. |
There's already an issue in the cmakemodules repo that talks about using ESMF's own findESMF.cmake: NOAA-EMC/CMakeModules#70 - there are also issues in fv3-jedi and spack for this if I remember correctly. |
@climbfuji is the findESMF.cmake issue caused by the new ESMF 8.6.1? I am curious why it is not an issue in previous ESMF 8.6.0. |
@climbfuji @junwang-noaa When I tests this change in UFS I had trouble IF I updated the UFS FindESMF.cmake files. If I left them alone then the UFS system built.
|
@danrosen25 Thanks for looking into this issue. My question is how to resolve the build issue when updating the ESMF8.6.1 and MAPL 2.46.2 in UFS weather model. I don't remember that ufs weather model has these three submodules. @BrianCurtis-NOAA @bbakernoaa @GeorgeGayno-NOAA FYI. The FindESMF,cmake in the repository Dan listed may need updates for ESMF 8.6.1. |
I'll try to find the log, but I updated all FindESMF.cmake in UFSWM and its sub-components to the one in the ESMF repo and CDEPS doesn't like the |
Note, I am on PTO until beginning of August - not sure how much I can help with this issue. @AlexanderRichert-NOAA also had experience these xxxxx ESMF vs esmf issues. |
@BrianCurtis-NOAA The FindESMF.cmake file included with ESMF creates a new variable So basically, CDEPS needs to run the current version of FindESMF.cmake included with CDEPS in order for the current code to work OR I've been making the case for independent component build steps, such as done when using the build infrastructure in ESMX. Setting all CMake variables in one place and letting global CMAKE variables affect builds for all components is hard to manage. |
@danrosen25 may I ask if you have the code updates for CDEPS so that we can move to ESMF 8.6.1? Thanks for looking into this issue. |
Does it not work with the existing version of FindESMF.cmake in CDEPS? But I think you need to change this line from Either that or change the CMakeLists.txt to |
It may be confusing that some cmake in CDEPS is for a "standalone" setup. I believe these are the relevant ones for UFS: |
Since that's the CMakeLists.txt file being used it's probably a case sensitivity issue. The target for ESMF is |
Note: GEOS is still has a few But until I can fix up all of GEOS, we have: if (NOT TARGET esmf)
add_library(esmf ALIAS ESMF::ESMF)
endif () in our code to still support the old style. I hope to remove it soon. |
Similar code can be added to UFS after this line: |
Where are we with this issue? Have [email protected] and [email protected] been installed on all NOAA RDHPCS systems in spack-stack-1.6.0? Or is this moot given that spack-stack-1.8.0 has [email protected] with [email protected]? |
MAPL 2.46.2 has a bug, we have to move to esmf 8.6.1 and mapl 2.46.3 to debug the issue. We suggest having a test version of spack-stack 1.6.0 with esmf 8.6.1 and mapl 2.46.3 to continue the debugging work, while you can move forward with spack-stack 1.8.0 release with esmf 8.6.1 and mapl 2.46.3 |
@RatkoVasic-NOAA FYI |
@mathomp4 we can continue to test on orion and hercules for the new versions of mapl and esmf. we can follow up at ufs-community/ufs-weather-model#2346. |
@RatkoVasic-NOAA installed a test env on orion/hercules w/ [email protected] and [email protected] in the following locations:
thank you @RatkoVasic-NOAA!!! |
Package name
ESMF and MAPL
Package version/tag
ESMF/8.6.1 and MAPL/2.46.2
Build options
Current
Installation timeframe
The two libraries will be installed under current spack-stack 1.6.0.
Other information
No response
WCOSS2
WCOSS2: General questions
No response
WCOSS2: Installation and testing
No response
WCOSS2: Technical & security review list
WCOSS2: Additional comments
No response
The text was updated successfully, but these errors were encountered: