Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency version of fkubis/teamspeak-php-framework #36

Open
element-code opened this issue Mar 17, 2019 · 1 comment
Open

Update dependency version of fkubis/teamspeak-php-framework #36

element-code opened this issue Mar 17, 2019 · 1 comment
Labels

Comments

@element-code
Copy link

The locked Version of fkubis/teamspeak-php-framework is not the latest commit.
This leads to a Pharse error on PHP 7.x (unset($this)).

Would be better anyway to exclude /vendor from git and do a composer install instead of a composer dump-autoload -o on installation.

@JABirchall
Copy link
Owner

JABirchall commented Mar 17, 2019

This is a remanent of the timeout issue #1 which was pending to be merged into fkubis repo for months.
I included the vendor directory with changes.
Feel free to put up a PR if you'd like. I see fkubis already has the unset fixed on his repo.

@JABirchall JABirchall added the bug label Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants