New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-9256]: Added TypeScript linting rule: prefer-for-of #424

Merged

mprew97 merged 2 commits into main from MOB-9256-prefer-for-of

Aug 5, 2024

Contributor

mprew97 commented Jul 31, 2024 •

edited by jira bot

Loading

JIRA Ticket(s) if any

MOB-9256

Description

There have been a lot of for loops over basic arrays in PRs lately. We should instead be using array iterations or for-of.

Test Steps


          new linting rules

a2e1d3c

lposen reviewed

View reviewed changes

.eslintrc Outdated

lposen Jul 31, 2024 •

edited

Loading

I was just thinking... we should probably find a way to standardize this across the entire frontend. It would be awesome if the eslint config in iterable-frontend could be importable.

cc: @nbaldwin @notyourbear

Contributor Author

mprew97 Aug 5, 2024

I agree, that's a good idea 👍

lposen reviewed

View reviewed changes

src/embedded/embeddedPlacement.ts Outdated Show resolved Hide resolved

lposen reviewed

View reviewed changes

src/embedded/embeddedPlacement.ts Outdated Show resolved Hide resolved

lposen reviewed

View reviewed changes

src/embedded/embeddedPlacement.ts Outdated Show resolved Hide resolved

lposen reviewed

View reviewed changes

src/embedded/embeddedPlacement.ts Outdated Show resolved Hide resolved

lposen reviewed

View reviewed changes

src/embedded/embeddedPlacement.ts Outdated Show resolved Hide resolved

lposen approved these changes

View reviewed changes

lposen left a comment

lgtm


          code cleanup

ca8eb6f

mprew97 merged commit f8ad569 into main

1 check passed

mprew97 deleted the MOB-9256-prefer-for-of branch

August 5, 2024 15:38

bradumbaugh changed the title ~~[MOB-9256]: prefer for-of~~ [MOB-9256]: Prefer for-of

bradumbaugh changed the title ~~[MOB-9256]: Prefer for-of~~ [MOB-9256]: Prefer map over for

bradumbaugh changed the title ~~[MOB-9256]: Prefer map over for~~ [MOB-9256]: Prefer "map" over "for"

bradumbaugh changed the title ~~[MOB-9256]: Prefer "map" over "for"~~ [MOB-9256]: Prefer map over for

bradumbaugh changed the title ~~[MOB-9256]: Prefer map over for~~ [MOB-9256]: Linting rule: prefer for-of

bradumbaugh changed the title ~~[MOB-9256]: Linting rule: prefer for-of~~ [MOB-9256]: Added linting rule: prefer for-of

bradumbaugh changed the title ~~[MOB-9256]: Added linting rule: prefer for-of~~ [MOB-9256]: Added TypeScript linting rule: prefer-for-of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet