Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-9066]: Better linting rules #421

Merged
merged 7 commits into from
Jul 23, 2024
Merged

[MOB-9066]: Better linting rules #421

merged 7 commits into from
Jul 23, 2024

Conversation

mprew97
Copy link
Contributor

@mprew97 mprew97 commented Jul 23, 2024 •
edited by jira bot
Loading

JIRA Ticket(s) if any

Description

Adds new linting rules

  • extends airbnb-base https://www.npmjs.com/package/eslint-config-airbnb-base
  • fixes a lot of linting issues
  • also disables a lot to drastically reduce the blast radius
  • this should at least make additional code cleaner and we will need to come back and clean up places where we are disabling the linter.

Test Steps

pauljung14
pauljung14 reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@pauljung14 pauljung14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls see comment re: src/inapp/request.ts in particular

react-example/src/components/EventsForm.tsx Outdated Show resolved Hide resolved
src/embedded/utils.ts Outdated Show resolved Hide resolved
src/inapp/request.ts Show resolved Hide resolved
@mprew97 mprew97 requested a review from pauljung14 July 23, 2024 15:51
@mprew97 mprew97 merged commit 50a9ff1 into main Jul 23, 2024
1 check passed
@mprew97 mprew97 deleted the MOB-9066-Attempt2 branch July 23, 2024 19:17
@bradumbaugh bradumbaugh changed the title [MOB-9066]: better linting rules [MOB-9066]: Better linting rules Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauljung14 pauljung14 pauljung14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mprew97 @pauljung14