notificiation view implemented #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mprew97
requested changes
Aug 7, 2023
mprew97
reviewed
Aug 7, 2023
| <div style={cardStyle}> | ||
| <h2>{title}</h2> | ||
| <p>{description}</p> | ||
| {primaryButtonLabel ? ( |
There was a problem hiding this comment.
nit: use && here and remove the need for : null
| {primaryButtonLabel} | ||
| </button> | ||
| ) : null} | ||
| {secondaryButtonLabel ? ( |
|
request you to please review the PR as it has been updated. |
Ty sir! We should be able to just import the |
|
Hi @mprew97 here is the video for the same: https://drive.google.com/file/d/1ifip1OplImM9m2q-kOXGwxNwenqJXkCC/view?usp=sharing |
mprew97
approved these changes
Aug 28, 2023
|
LGTM, please fix the build issues and then this can be merged. |
mprew97
added a commit
that referenced
this pull request
Jun 12, 2024
* notificiation view implemented (#212) * notificiation view implemented * code changes as per recent review * usage of banner view * usage of notification view * Webpack config changed for Notification View --------- Co-authored-by: Vishal Joshi <[email protected]> * Embedded msg (#232) * Embedded Manager Module - WIP * Embedded Manager Module - added uuid library * Code modified for embedded msg * Documentation added * Events example added * Embedded msg configurations changed * Import issue of embeddedManager fixed * Circuler dependency solved * Linting error fixing * events code break down into separate folders * Import issues fixed --------- Co-authored-by: Vishal Joshi <[email protected]> * Embedded test (#234) * Embedded Manager Module - WIP * Embedded Manager Module - added uuid library * Code modified for embedded msg * Documentation added * Events example added * Test Cases added for embedded message manager * Added Embedded Placement Test cases * EmbeddedMsg Test Cases added * embeddedManager import issue fixed * Linting error resolved * Test issues resolved * basic changes to run the code * change query params of get embedded messaging api * remove code for embedded messaging sync parameters * revert the changes that were made earlier to run the code. --------- Co-authored-by: Vishal Joshi <[email protected]> Co-authored-by: Hani <[email protected]> * Embedded msgs example (#233) * card view implemented * code changes as per recent review * Embedded Manager Module - WIP * Embedded Manager Module - added uuid library * usage of card view * Code modified for embedded msg * Documentation added * Events example added * Embedded msg example with card view * Embedded msg example updated * build config changed and few updates done on card component * react-example improved * Node webpack config changed * Webpack config changed * Yarn file issue fixed * Resolve revice comments --------- Co-authored-by: iamavishkar <[email protected]> Co-authored-by: Vishal Joshi <[email protected]> Co-authored-by: Hani <[email protected]> * Embedded Messaging Dismiss Event Track (#241) * set embedded message dismiss event * remove unnecessary file * display API response to the embedded page * Resolve review comments --------- Co-authored-by: Hani <[email protected]> * Dev 248 (Update payload to include updated placements) (#242) * Embedded Manager Module - WIP * Embedded Manager Module - added uuid library * Code modified for embedded msg * Documentation added * Events example added * Test Cases added for embedded message manager * Added Embedded Placement Test cases * EmbeddedMsg Test Cases added * embeddedManager import issue fixed * Linting error resolved * Test issues resolved * basic changes to run the code * change query params of get embedded messaging api * change placementIds param format in API query param * change query param in sample app * make placement id param optional * modify test case accordingly --------- Co-authored-by: Vishal Joshi <[email protected]> Co-authored-by: Hani <[email protected]> * banner view implemented (#213) * banner view implemented * code changes as per recent review * usage of banner view * Banner View Webpack config changed * .babelrc config changed * [MOB-7175]: add new filter method that leaves in JSON only messages (#238) * add new filter method that leaves in JSON only messages * Mentioning filterOnlyReadAndNeverTriggerMessages --------- Co-authored-by: mitch prewitt <[email protected]> Co-authored-by: Brad Umbaugh <[email protected]> * ver bump (#240) Co-authored-by: mitch prewitt <[email protected]> --------- Co-authored-by: Vishal Joshi <[email protected]> Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Mitch Prewitt <[email protected]> Co-authored-by: mitch prewitt <[email protected]> Co-authored-by: Brad Umbaugh <[email protected]> Co-authored-by: Hani <[email protected]> * card view implemented (#214) * card view implemented * code changes as per recent review * usage of card view * build config changed and few updates done on card component * react-example improved * Node webpack config changed * Webpack config changed --------- Co-authored-by: Vishal Joshi <[email protected]> Co-authored-by: Hani <[email protected]> Co-authored-by: Mitch Prewitt <[email protected]> * Add embedded views to the SDK & integrate into sample app (#243) * card view implemented * code changes as per recent review * Embedded Manager Module - WIP * Embedded Manager Module - added uuid library * usage of card view * Code modified for embedded msg * Documentation added * Events example added * Embedded msg example with card view * Embedded msg example updated * build config changed and few updates done on card component * react-example improved * Create manual.yml * Node webpack config changed * Webpack config changed * Yarn file issue fixed * [MOB-7175]: add new filter method that leaves in JSON only messages (#238) * add new filter method that leaves in JSON only messages * Mentioning filterOnlyReadAndNeverTriggerMessages --------- Co-authored-by: mitch prewitt <[email protected]> Co-authored-by: Brad Umbaugh <[email protected]> * ver bump (#240) Co-authored-by: mitch prewitt <[email protected]> * embedded msg view integration * integrate demo in sample app * Resolve node build issue * commit remaining code * commit remaining files --------- Co-authored-by: iamavishkar <[email protected]> Co-authored-by: Vishal Joshi <[email protected]> Co-authored-by: Mitch Prewitt <[email protected]> Co-authored-by: mitch prewitt <[email protected]> Co-authored-by: Brad Umbaugh <[email protected]> Co-authored-by: Hani <[email protected]> * Add remaining events to web embedded messaging * update the test cases * Add remaining events to web embedded messaging * Add remaining events to web embedded messaging * Revert "Add remaining events to web embedded messaging" This reverts commit 3704505. * Update events.test.ts * Add remaining events to web embedded messaging (#245) * Add remaining events to web embedded messaging * Resolve review comments --------- Co-authored-by: Hani Vora <[email protected]> * resolve build error issue using dev config * Create test (#250) (#252) * Create test (#250) * Create test * Update yarn.lock (#251) * Update events.schema.ts (#257) * Update types.ts (#262) * Update events.schema.ts (#259) * Update EmbeddedForm.tsx (#253) * Delete test (#254) * Update EmbeddedMsgs.tsx (#255) * Update embeddedManager.ts (#256) * Update types.ts (#258) * Update events.test.ts (#260) * Update events.ts (#261) * Update EmbeddedForm.tsx (#290) * Create Functions.ts (#291) * Update embeddedManager.ts (#292) * Update events.ts (#293) * Create functions (#294) * Rename functions to functions.ts (#298) * Update embeddedManager.test.ts (#299) * Embedded received event (#278) * change in embedded api params * Update EmbeddedMsgs.tsx (#263) * Update index.tsx (#264) * Update index.tsx (#265) * Update index.tsx (#266) * Update embeddedManager.ts (#267) * Update index.ts (#268) * Update events.schema.ts (#270) * Update types.ts (#271) * Update yarn.lock (#272) * Create IterableActionRunner.ts (#274) * Update embeddedManager.ts (#276) * Update types.ts (#277) * Resolve build fail issue (#289) * Resolve merge conflicts * Embedded msg image (#286) * Create test (#250) * Create test * Update yarn.lock (#251) * Update events.schema.ts (#257) * Update types.ts (#262) * Update events.schema.ts (#259) * Update EmbeddedForm.tsx (#253) * Delete test (#254) * Update EmbeddedMsgs.tsx (#255) * Update embeddedManager.ts (#256) * Update types.ts (#258) * Update events.test.ts (#260) * Update events.ts (#261) * Update index.tsx (#284) * Update index.tsx (#285) * Resolve merge conflicts * Embedded text wrap (#283) * Create test (#250) * Create test * Update yarn.lock (#251) * Update events.schema.ts (#257) * Update types.ts (#262) * Update events.schema.ts (#259) * Update EmbeddedForm.tsx (#253) * Delete test (#254) * Update EmbeddedMsgs.tsx (#255) * Update embeddedManager.ts (#256) * Update types.ts (#258) * Update events.test.ts (#260) * Update events.ts (#261) * Update index.tsx (#279) * Update index.tsx (#280) * Update index.ts (#281) * Update index.tsx (#282) * Update index.tsx (#295) * Update index.tsx (#296) * Update index.tsx (#297) * Embedded message button click (#273) * change in embedded api params * Update EmbeddedMsgs.tsx (#263) * Update index.tsx (#264) * Update index.tsx (#265) * Update index.tsx (#266) * Update embeddedManager.ts (#267) * Update index.ts (#268) * Update events.schema.ts (#270) * Update types.ts (#271) * Update yarn.lock (#272) * Create IterableActionRunner.ts (#274) * Remove unused code (#275) * Update embeddedManager.ts (#287) * resolve error for OOTB not responding properly (#309) * Resolve: Content not aligned for notification view (#310) * set text align for default style (#311) * make cursor to pointer (#312) * Make UI responsive (#314) * Make UI responsive * Resolve review comments * Mob 7843 (#307) * set message if message is not available * resolve review comments * MOB-7859 (Long buttons become stacked) (#315) * modify button UI * resolve merge conflicts * Lower `[email protected]` version (#316) * make OOTB views unavailable for Beta (#319) * remove markdown files for embedded (#326) Co-authored-by: mitch prewitt <[email protected]> * remove ActionHandler (#321) * update the doc (#323) * Handling incoming embedded messages (#320) * Handling incoming embedded messages * add missing requirement * Update embeddedManager.test.ts * resolve merge conflicts * Support custom as well default click handler (#317) * Support custom as well default click handler * remove circular dependency * Resolve PR comments * fix conflicts (#327) Co-authored-by: mitch prewitt <[email protected]> * Mob 8058 (Web SDK: Click Handling) (#328) * Implement for embedded click * modify test cases * Resolve review comments * change import path to resolve build error * resolve build failure * resolve review comments * Resolve circular dependency --------- Co-authored-by: Mitch Prewitt <[email protected]> * update styles (#329) Co-authored-by: mitch prewitt <[email protected]> * update (#330) Co-authored-by: mitch prewitt <[email protected]> * session track (#331) Co-authored-by: mitch prewitt <[email protected]> * add uuid as session ID (#332) * Resolve errors (#333) * fix (#340) Co-authored-by: mitch prewitt <[email protected]> * Remove console statements (#341) * fix * fix --------- Co-authored-by: mitch prewitt <[email protected]> * bump version 1.1.0-beta (#342) * Fix beta publish issue (#344) * fix publish issue * revert lock changes * fix * now? --------- Co-authored-by: mitch prewitt <[email protected]> * OOTB Rework: Need to be pure JS/HTML/CSS (#354) * OOTB Rework: Need to be pure JS/HTML/CSS * OOTB Rework: Need to be pure JS/HTML/CSS * added id of all component * added custom changes * fixed click issue * fixed comments * handled click by elements name * updated example * fixed cursor pointer * Update EmbeddedMsgs.tsx (sample code) to use EmbeddedMessageUpdateHandler * fixed client's comments * Fixed comments * updated click events as common * HTTP call in retrieveEmbeddedMessages (#355) * HTTP call in retrieveEmbeddedMessages * updated test file * sdk and platform updated * updated test file --------- Co-authored-by: hardikmashru <[email protected]> --------- Co-authored-by: hardikmashru <[email protected]> * Web SDK is incorrectly parsing custom action objects (#358) * OOTB Rework: Need to be pure JS/HTML/CSS * OOTB Rework: Need to be pure JS/HTML/CSS * added id of all component * added custom changes * fixed click issue * fixed comments * handled click by elements name * updated example * fixed cursor pointer * Update EmbeddedMsgs.tsx (sample code) to use EmbeddedMessageUpdateHandler * HTTP call in retrieveEmbeddedMessages * updated test file * fixed client's comments * Fixed comments * updated click events as common * sdk and platform updated * updated test file * Web SDK is incorrectly parsing custom action objects * updated listener name and handle callback * Updated custom action object type * HTTP call in retrieveEmbeddedMessages (#355) * HTTP call in retrieveEmbeddedMessages * updated test file * sdk and platform updated * updated test file --------- Co-authored-by: hardikmashru <[email protected]> * Too many Embedded-related interfaces? (#359) * Updated interfaces * removed duplicate interface from in-app * Updated IEmbeddedMessage in events * Updated EnbeddedMessagingDismiss, EnbeddedMessagingSession * Removed unused interfaces * Removed unused interfaces * Updated test.ts --------- Co-authored-by: hardikmashru <[email protected]> * updated code in useeffect * pass package name and expose trackembeddedclick as standalone function (#363) --------- Co-authored-by: hardikmashru <[email protected]> * Update Embedded requests to not need to pass userId or email (#364) * OOTB Rework: Need to be pure JS/HTML/CSS * OOTB Rework: Need to be pure JS/HTML/CSS * added id of all component * added custom changes * fixed click issue * fixed comments * handled click by elements name * updated example * fixed cursor pointer * Update EmbeddedMsgs.tsx (sample code) to use EmbeddedMessageUpdateHandler * HTTP call in retrieveEmbeddedMessages * updated test file * fixed client's comments * Fixed comments * updated click events as common * sdk and platform updated * updated test file * Web SDK is incorrectly parsing custom action objects * updated listener name and handle callback * Updated custom action object type * HTTP call in retrieveEmbeddedMessages (#355) * HTTP call in retrieveEmbeddedMessages * updated test file * sdk and platform updated * updated test file --------- Co-authored-by: hardikmashru <[email protected]> * Too many Embedded-related interfaces? (#359) * Updated interfaces * removed duplicate interface from in-app * Updated IEmbeddedMessage in events * Updated EnbeddedMessagingDismiss, EnbeddedMessagingSession * Removed unused interfaces * Removed unused interfaces * Updated test.ts --------- Co-authored-by: hardikmashru <[email protected]> * updated code in useeffect * pass package name and expose trackembeddedclick as standalone function * Update Embedded requests to not need to pass userId or email * removed unused code from test * Updated endpoints in setUserId and setEmail * added impression endpoint --------- Co-authored-by: hardikmashru <[email protected]> * Rework Embedded Session Manager (#362) * OOTB Rework: Need to be pure JS/HTML/CSS * OOTB Rework: Need to be pure JS/HTML/CSS * added id of all component * added custom changes * fixed click issue * fixed comments * handled click by elements name * updated example * fixed cursor pointer * Update EmbeddedMsgs.tsx (sample code) to use EmbeddedMessageUpdateHandler * HTTP call in retrieveEmbeddedMessages * updated test file * sdk and platform updated * updated test file * Web SDK is incorrectly parsing custom action objects * updated listener name and handle callback * Updated custom action object type * Too many Embedded-related interfaces? (#359) * Updated interfaces * removed duplicate interface from in-app * Updated IEmbeddedMessage in events * Updated EnbeddedMessagingDismiss, EnbeddedMessagingSession * Removed unused interfaces * Removed unused interfaces * Updated test.ts --------- Co-authored-by: hardikmashru <[email protected]> * Rework Embedded Session Manager * Updated messageId * Update types.ts * Update EmbeddedMsgs.tsx * Fixed end session event in SDK --------- Co-authored-by: hardikmashru <[email protected]> * [MOB-8148]: clean up embedded types (#365) * OOTB Rework: Need to be pure JS/HTML/CSS * OOTB Rework: Need to be pure JS/HTML/CSS * added id of all component * added custom changes * fixed click issue * fixed comments * handled click by elements name * updated example * fixed cursor pointer * Update EmbeddedMsgs.tsx (sample code) to use EmbeddedMessageUpdateHandler * HTTP call in retrieveEmbeddedMessages * updated test file * sdk and platform updated * updated test file * Web SDK is incorrectly parsing custom action objects * updated listener name and handle callback * Updated custom action object type * Too many Embedded-related interfaces? (#359) * Updated interfaces * removed duplicate interface from in-app * Updated IEmbeddedMessage in events * Updated EnbeddedMessagingDismiss, EnbeddedMessagingSession * Removed unused interfaces * Removed unused interfaces * Updated test.ts --------- Co-authored-by: hardikmashru <[email protected]> * Rework Embedded Session Manager * Updated messageId * Update types.ts * Update EmbeddedMsgs.tsx * remove react dep * Fixed end session event in SDK * checking * need to see * remove dupe schema * cleanup * clean up packages and more * typo * fix tests and change requests * further change requests * oop * fix circular deps * additional cleanup and rework * fix embeddedManager test * fix base branch issues * rename to iterable * update OOTB names * export --------- Co-authored-by: hardikmashru <[email protected]> Co-authored-by: hardikmashru <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: mitch prewitt <[email protected]> * [MOB-8405]: Add new eslint rules (#367) * OOTB Rework: Need to be pure JS/HTML/CSS * OOTB Rework: Need to be pure JS/HTML/CSS * added id of all component * added custom changes * fixed click issue * fixed comments * handled click by elements name * updated example * fixed cursor pointer * Update EmbeddedMsgs.tsx (sample code) to use EmbeddedMessageUpdateHandler * HTTP call in retrieveEmbeddedMessages * updated test file * sdk and platform updated * updated test file * Web SDK is incorrectly parsing custom action objects * updated listener name and handle callback * Updated custom action object type * Too many Embedded-related interfaces? (#359) * Updated interfaces * removed duplicate interface from in-app * Updated IEmbeddedMessage in events * Updated EnbeddedMessagingDismiss, EnbeddedMessagingSession * Removed unused interfaces * Removed unused interfaces * Updated test.ts --------- Co-authored-by: hardikmashru <[email protected]> * Rework Embedded Session Manager * Updated messageId * Update types.ts * Update EmbeddedMsgs.tsx * remove react dep * Fixed end session event in SDK * checking * need to see * remove dupe schema * cleanup * clean up packages and more * typo * fix tests and change requests * further change requests * oop * fix circular deps * additional cleanup and rework * fix embeddedManager test * fix base branch issues * update lint rules * more tweaks --------- Co-authored-by: hardikmashru <[email protected]> Co-authored-by: hardikmashru <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: mitch prewitt <[email protected]> * MOB-8139 & MOB-8028 (#369) * pushed changes * Error handling for trackEmbeddedClick Error handling for trackEmbeddedClick * sample app changes * revert unnecessary react-example changes * revert react-example unnecessary changes * implemented changes as per review suggestions * Update request.ts * create utility method for getting url from action (#371) create utility method for getting url from action * [MOB-8416]: easier UUID testing in sample app (#374) * easier UUID testing in sample app * some cleanup and change request additions --------- Co-authored-by: mitch prewitt <[email protected]> * fix focus bug and console error (#377) Co-authored-by: mitch prewitt <[email protected]> * [MOB-8425]: strengthen network interceptors (#376) * easier UUID testing in sample app * hopping * update interceptors and routes * oops * accidental delete from merge * forgot route * wrong route * oops * Update src/constants.ts Co-authored-by: Paul Jung <[email protected]> * update const name --------- Co-authored-by: mitch prewitt <[email protected]> Co-authored-by: Paul Jung <[email protected]> * [MOB-8475]: Remove Sample TImeout (#379) * easier UUID testing in sample app * hopping * update interceptors and routes * oops * accidental delete from merge * forgot route * wrong route * oops * Update src/constants.ts Co-authored-by: Paul Jung <[email protected]> * update const name * remove timeout --------- Co-authored-by: mitch prewitt <[email protected]> Co-authored-by: Paul Jung <[email protected]> * MOB 8472 (#390) * pushed changes * Update LoginForm.tsx * fix cardView, notificationView, bannerView * fix aspect-ratio, padding * fix margin-top for banner image * revert LoginForm changes * final fix card, banner, notification view * UI fixes, responsive fixes and impression tracker screen fixes * put back env.example * rename env.example * removed inline style * rollback for unnecessary PR diff * Update index.tsx * update .evn.example * fix card, banner, notification view * updates * escape htmltext --------- Co-authored-by: Hardik Mashru <[email protected]> * Fixing placementIds issue on IterableEmbeddedManager (#392) * [MOB-8503]: refactor OOTB views (#391) * mostly up to date * updates * teeny * button cleanup * oop * add style update examples * jsdoc comments --------- Co-authored-by: mitch prewitt <[email protected]> * MOB-8604 (#394) * update trackNewlyRetrieved * clean up --------- Co-authored-by: mitch prewitt <[email protected]> * MOB-8600 (#393) * expose handleEmbeddedClick * fix embeddedClick alias * Update utils.ts * Update utils.ts * rename --------- Co-authored-by: mitch prewitt <[email protected]> * [MOB-8639]: add elements to OOTB type (#395) * add elements to OOTB type * update var name --------- Co-authored-by: mitch prewitt <[email protected]> * [MOB-8646]: targetUrl not being sent on click (#400) * update to target url * update func name --------- Co-authored-by: mitch prewitt <[email protected]> * jwt-gen param issue (#402) Co-authored-by: mitch prewitt <[email protected]> --------- Co-authored-by: Avishkar Singh <[email protected]> Co-authored-by: Vishal Joshi <[email protected]> Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hani <[email protected]> Co-authored-by: iamavishkar <[email protected]> Co-authored-by: mitch prewitt <[email protected]> Co-authored-by: Brad Umbaugh <[email protected]> Co-authored-by: Hani Vora <[email protected]> Co-authored-by: Hani Vora <[email protected]> Co-authored-by: Justin Yu <[email protected]> Co-authored-by: hardikmashru <[email protected]> Co-authored-by: hardikmashru <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: Paul Jung <[email protected]> Co-authored-by: Hardik Mashru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket(s) if any
Description
Test Steps