Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-9536] criteria is incorrectly matching on a simple isSet custom event criteria #797

Open
wants to merge 4 commits into
base: feature/itbl-track-anon-user
Choose a base branch
from
Open

[MOB-9536] criteria is incorrectly matching on a simple isSet custom event criteria #797

wants to merge 4 commits into from

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Sep 16, 2024 •
edited by jira bot
Loading

🔹 Jira Ticket(s) if any

✏️ Description

This pull request addresses the bug where criteria were incorrectly matching for isSet criteria. There was an incorrectly placed return statement that was causing the result to be prematurely returned as true before checking the data fields.

@evantk91 evantk91 changed the base branch from master to feature/itbl-track-anon-user September 16, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ayyanchira Ayyanchira Awaiting requested review from Ayyanchira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@evantk91