Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-9571] refactors evaluateTree #796

Merged
merged 9 commits into from
Sep 27, 2024
Merged

[MOB-9571] refactors evaluateTree #796

merged 9 commits into from
Sep 27, 2024

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Sep 16, 2024 •
edited by jira bot
Loading

🔹 Jira Ticket(s) if any

✏️ Description

This pull request includes refactoring of remaining criteria completion logic.

@evantk91 evantk91 marked this pull request as draft September 16, 2024 17:00
@evantk91 evantk91 marked this pull request as ready for review September 17, 2024 00:01
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 85.93750% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (evan/MOB-9572@0cbfce5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...le/iterableapi/util/CriteriaCompletionChecker.java 85.93% 3 Missing and 6 partials ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##             evan/MOB-9572     #796   +/-   ##
================================================
  Coverage                 ?   59.49%           
================================================
  Files                    ?       84           
  Lines                    ?     5834           
  Branches                 ?      725           
================================================
  Hits                     ?     3471           
  Misses                   ?     1994           
  Partials                 ?      369

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evantk91
Copy link
Contributor Author

evantk91 commented Sep 17, 2024 •
edited by jira bot
Loading

🔹 Jira Ticket(s) if any

✏️ Description

This pull request includes refactoring of remaining criteria completion logic.

Excludes evaluateFieldLogic and evaluateSearchQueries. I want to do on a separate PR since these are fairly complex logic.

@evantk91 evantk91 self-assigned this Sep 23, 2024
Ayyanchira
Ayyanchira approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a refactor! Made some nit pick comments.

iterableapi/src/main/java/com/iterable/iterableapi/util/CriteriaCompletionChecker.java Show resolved Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/util/CriteriaCompletionChecker.java Show resolved Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/util/CriteriaCompletionChecker.java Show resolved Hide resolved
@evantk91 evantk91 merged commit ba85147 into evan/MOB-9572 Sep 27, 2024
4 checks passed
@evantk91 evantk91 deleted the evan/MOB-9571 branch September 27, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ayyanchira Ayyanchira Ayyanchira approved these changes

Assignees

@evantk91 evantk91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evantk91 @Ayyanchira