Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove identities from the regular contact list? #255

Open
dnotestein opened this issue Jan 27, 2014 · 0 comments
Open

Remove identities from the regular contact list? #255

dnotestein opened this issue Jan 27, 2014 · 0 comments
Labels

Comments

@dnotestein
Copy link
Member

Currently we're storing identities both on their own list and also in the "contacts" list. I think we should stop adding them to the contacts list, and instead allow editing them on a separate list that is just for identities. We've discussed this before and put it aside, but I think it's the best way to go in the long run from a usability point of view, and it'll also simplify the coding I think. So I'm suggesting we add another element to the navigation tree (that currently has email, wallet, and contacts). Above Contacts, we would add Identities. Since identities derive from contacts, we can re-use a lot of the GUI contact editing/display code.

Hmm, so identity is derived from contact, not from wallet_contact, so code reuse will be a little more difficult than I thought. I left an earlier comment in the code to consider deriving identity from wallet_contact instead. The problem with changing to that now is it would force us to invalidate a lot of existing profiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant