Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Evaluation] [Performance] Remove scope checking #6662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Evaluation] [Performance] Remove scope checking #6662

wants to merge 1 commit into from

Conversation

effectfully
Copy link
Contributor

Just being curious.

@effectfully effectfully self-assigned this Nov 14, 2024
@IntersectMBO IntersectMBO deleted a comment from github-actions bot Nov 14, 2024
@IntersectMBO IntersectMBO deleted a comment from github-actions bot Nov 14, 2024
@IntersectMBO IntersectMBO deleted a comment from github-actions bot Nov 14, 2024
@IntersectMBO IntersectMBO deleted a comment from github-actions bot Nov 14, 2024
@IntersectMBO IntersectMBO deleted a comment from github-actions bot Nov 14, 2024
@IntersectMBO IntersectMBO deleted a comment from github-actions bot Nov 14, 2024
@IntersectMBO IntersectMBO deleted a comment from github-actions bot Nov 14, 2024
@IntersectMBO IntersectMBO deleted a comment from github-actions bot Nov 14, 2024
@IntersectMBO IntersectMBO deleted a comment from github-actions bot Nov 14, 2024
@IntersectMBO IntersectMBO deleted a comment from github-actions bot Nov 14, 2024
@effectfully
Copy link
Contributor Author

/benchmark validation-full

1 similar comment
@effectfully
Copy link
Contributor Author

/benchmark validation-full

@github-actions GitHub Actions
Copy link
Contributor

Click here to check the status of your benchmark.

@github-actions GitHub Actions
Copy link
Contributor

Comparing benchmark results of 'validation-full' on 'c082e28591' (base) and '5e94541fef' (PR)

Results table
Script c082e28 5e94541 Change
auction_1-1 627.3 μs 606.8 μs -3.3%
auction_1-2 2.131 ms 2.069 ms -2.9%
auction_1-3 2.135 ms 2.077 ms -2.7%
auction_1-4 708.8 μs 692.9 μs -2.2%
auction_2-1 627.9 μs 607.2 μs -3.3%
auction_2-2 2.127 ms 2.070 ms -2.7%
auction_2-3 2.484 ms 2.440 ms -1.8%
auction_2-4 2.127 ms 2.077 ms -2.4%
auction_2-5 708.6 μs 692.4 μs -2.3%
crowdfunding-success-1 761.2 μs 735.9 μs -3.3%
crowdfunding-success-2 762.0 μs 738.1 μs -3.1%
crowdfunding-success-3 762.6 μs 736.9 μs -3.4%
currency-1 824.3 μs 810.7 μs -1.6%
escrow-redeem_1-1 1.148 ms 1.107 ms -3.6%
escrow-redeem_1-2 1.150 ms 1.107 ms -3.7%
escrow-redeem_2-1 1.244 ms 1.209 ms -2.8%
escrow-redeem_2-2 1.245 ms 1.208 ms -3.0%
escrow-redeem_2-3 1.245 ms 1.212 ms -2.7%
escrow-refund-1 824.5 μs 781.8 μs -5.2%
future-increase-margin-1 824.0 μs 802.4 μs -2.6%
future-increase-margin-2 1.471 ms 1.440 ms -2.1%
future-increase-margin-3 1.471 ms 1.441 ms -2.0%
future-increase-margin-4 2.134 ms 2.035 ms -4.6%
future-increase-margin-5 2.723 ms 2.667 ms -2.1%
future-pay-out-1 823.5 μs 810.3 μs -1.6%
future-pay-out-2 1.472 ms 1.440 ms -2.2%
future-pay-out-3 1.472 ms 1.440 ms -2.2%
future-pay-out-4 2.720 ms 2.637 ms -3.1%
future-settle-early-1 824.0 μs 800.7 μs -2.8%
future-settle-early-2 1.470 ms 1.442 ms -1.9%
future-settle-early-3 1.472 ms 1.441 ms -2.1%
future-settle-early-4 2.339 ms 2.244 ms -4.1%
game-sm-success_1-1 1.626 ms 1.580 ms -2.8%
game-sm-success_1-2 607.9 μs 588.8 μs -3.1%
game-sm-success_1-3 2.094 ms 2.050 ms -2.1%
game-sm-success_1-4 658.0 μs 589.1 μs -10.5%
game-sm-success_2-1 1.626 ms 1.581 ms -2.8%
game-sm-success_2-2 607.5 μs 588.5 μs -3.1%
game-sm-success_2-3 2.092 ms 2.049 ms -2.1%
game-sm-success_2-4 658.1 μs 590.1 μs -10.3%
game-sm-success_2-5 2.093 ms 2.050 ms -2.1%
game-sm-success_2-6 658.9 μs 589.4 μs -10.5%
multisig-sm-1 1.763 ms 1.709 ms -3.1%
multisig-sm-2 1.746 ms 1.689 ms -3.3%
multisig-sm-3 1.752 ms 1.676 ms -4.3%
multisig-sm-4 1.757 ms 1.704 ms -3.0%
multisig-sm-5 2.058 ms 2.007 ms -2.5%
multisig-sm-6 1.764 ms 1.708 ms -3.2%
multisig-sm-7 1.745 ms 1.686 ms -3.4%
multisig-sm-8 1.754 ms 1.695 ms -3.4%
multisig-sm-9 1.760 ms 1.705 ms -3.1%
multisig-sm-10 2.059 ms 1.989 ms -3.4%
ping-pong-1 1.458 ms 1.415 ms -2.9%
ping-pong-2 1.456 ms 1.413 ms -3.0%
ping-pong_2-1 1.231 ms 1.179 ms -4.2%
prism-1 546.4 μs 533.9 μs -2.3%
prism-2 1.659 ms 1.611 ms -2.9%
prism-3 1.022 ms 1.007 ms -1.5%
pubkey-1 512.7 μs 481.8 μs -6.0%
stablecoin_1-1 3.304 ms 3.194 ms -3.3%
stablecoin_1-2 601.8 μs 581.4 μs -3.4%
stablecoin_1-3 3.565 ms 3.479 ms -2.4%
stablecoin_1-4 617.1 μs 605.3 μs -1.9%
stablecoin_1-5 4.162 ms 4.113 ms -1.2%
stablecoin_1-6 691.5 μs 681.1 μs -1.5%
stablecoin_2-1 3.302 ms 3.193 ms -3.3%
stablecoin_2-2 600.9 μs 582.0 μs -3.1%
stablecoin_2-3 3.560 ms 3.478 ms -2.3%
stablecoin_2-4 615.9 μs 605.9 μs -1.6%
token-account-1 727.4 μs 708.6 μs -2.6%
token-account-2 934.5 μs 901.7 μs -3.5%
uniswap-1 1.096 ms 1.081 ms -1.4%
uniswap-2 784.5 μs 762.5 μs -2.8%
uniswap-3 4.531 ms 4.480 ms -1.1%
uniswap-4 847.7 μs 831.1 μs -2.0%
uniswap-5 3.367 ms 3.302 ms -1.9%
uniswap-6 824.5 μs 813.4 μs -1.3%
vesting-1 1.165 ms 1.127 ms -3.3%
c082e28 5e94541 Change
TOTAL 118.9 ms 115.6 ms -2.8%

@github-actions GitHub Actions
Copy link
Contributor

Click here to check the status of your benchmark.

@effectfully
Copy link
Contributor Author

/benchmark validation-full

@github-actions GitHub Actions
Copy link
Contributor

Comparing benchmark results of 'validation-full' on 'c082e28591' (base) and '5e94541fef' (PR)

Results table
Script c082e28 5e94541 Change
auction_1-1 629.9 μs 605.3 μs -3.9%
auction_1-2 2.141 ms 2.086 ms -2.6%
auction_1-3 2.140 ms 2.076 ms -3.0%
auction_1-4 710.2 μs 692.1 μs -2.5%
auction_2-1 628.9 μs 606.6 μs -3.5%
auction_2-2 2.138 ms 2.067 ms -3.3%
auction_2-3 2.497 ms 2.436 ms -2.4%
auction_2-4 2.140 ms 2.077 ms -2.9%
auction_2-5 710.1 μs 691.8 μs -2.6%
crowdfunding-success-1 763.7 μs 736.1 μs -3.6%
crowdfunding-success-2 764.3 μs 736.5 μs -3.6%
crowdfunding-success-3 764.4 μs 737.2 μs -3.6%
currency-1 829.1 μs 800.4 μs -3.5%
escrow-redeem_1-1 1.155 ms 1.108 ms -4.1%
escrow-redeem_1-2 1.154 ms 1.107 ms -4.1%
escrow-redeem_2-1 1.252 ms 1.208 ms -3.5%
escrow-redeem_2-2 1.251 ms 1.209 ms -3.4%
escrow-redeem_2-3 1.249 ms 1.208 ms -3.3%
escrow-refund-1 828.2 μs 781.6 μs -5.6%
future-increase-margin-1 828.2 μs 800.1 μs -3.4%
future-increase-margin-2 1.477 ms 1.441 ms -2.4%
future-increase-margin-3 1.478 ms 1.442 ms -2.4%
future-increase-margin-4 2.143 ms 2.033 ms -5.1%
future-increase-margin-5 2.735 ms 2.664 ms -2.6%
future-pay-out-1 828.5 μs 801.3 μs -3.3%
future-pay-out-2 1.476 ms 1.442 ms -2.3%
future-pay-out-3 1.477 ms 1.440 ms -2.5%
future-pay-out-4 2.734 ms 2.661 ms -2.7%
future-settle-early-1 829.1 μs 809.6 μs -2.4%
future-settle-early-2 1.477 ms 1.440 ms -2.5%
future-settle-early-3 1.477 ms 1.441 ms -2.4%
future-settle-early-4 2.341 ms 2.240 ms -4.3%
game-sm-success_1-1 1.632 ms 1.562 ms -4.3%
game-sm-success_1-2 609.4 μs 587.7 μs -3.6%
game-sm-success_1-3 2.101 ms 2.027 ms -3.5%
game-sm-success_1-4 661.0 μs 587.1 μs -11.2%
game-sm-success_2-1 1.633 ms 1.560 ms -4.5%
game-sm-success_2-2 609.3 μs 587.9 μs -3.5%
game-sm-success_2-3 2.102 ms 2.029 ms -3.5%
game-sm-success_2-4 660.5 μs 590.0 μs -10.7%
game-sm-success_2-5 2.101 ms 2.049 ms -2.5%
game-sm-success_2-6 658.8 μs 586.9 μs -10.9%
multisig-sm-1 1.771 ms 1.708 ms -3.6%
multisig-sm-2 1.752 ms 1.665 ms -5.0%
multisig-sm-3 1.762 ms 1.676 ms -4.9%
multisig-sm-4 1.768 ms 1.704 ms -3.6%
multisig-sm-5 2.070 ms 1.986 ms -4.1%
multisig-sm-6 1.772 ms 1.689 ms -4.7%
multisig-sm-7 1.751 ms 1.669 ms -4.7%
multisig-sm-8 1.763 ms 1.696 ms -3.8%
multisig-sm-9 1.770 ms 1.685 ms -4.8%
multisig-sm-10 2.066 ms 2.009 ms -2.8%
ping-pong-1 1.460 ms 1.414 ms -3.2%
ping-pong-2 1.462 ms 1.397 ms -4.4%
ping-pong_2-1 1.237 ms 1.179 ms -4.7%
prism-1 547.0 μs 534.4 μs -2.3%
prism-2 1.664 ms 1.592 ms -4.3%
prism-3 1.026 ms 1.008 ms -1.8%
pubkey-1 514.1 μs 480.7 μs -6.5%
stablecoin_1-1 3.322 ms 3.162 ms -4.8%
stablecoin_1-2 601.9 μs 587.1 μs -2.5%
stablecoin_1-3 3.585 ms 3.476 ms -3.0%
stablecoin_1-4 617.6 μs 605.3 μs -2.0%
stablecoin_1-5 4.182 ms 4.082 ms -2.4%
stablecoin_1-6 691.8 μs 681.9 μs -1.4%
stablecoin_2-1 3.316 ms 3.162 ms -4.6%
stablecoin_2-2 603.1 μs 581.7 μs -3.5%
stablecoin_2-3 3.578 ms 3.478 ms -2.8%
stablecoin_2-4 618.1 μs 605.2 μs -2.1%
token-account-1 732.5 μs 708.0 μs -3.3%
token-account-2 931.9 μs 899.8 μs -3.4%
uniswap-1 1.102 ms 1.071 ms -2.8%
uniswap-2 788.3 μs 753.4 μs -4.4%
uniswap-3 4.569 ms 4.480 ms -1.9%
uniswap-4 849.1 μs 830.7 μs -2.2%
uniswap-5 3.393 ms 3.300 ms -2.7%
uniswap-6 825.9 μs 813.9 μs -1.5%
vesting-1 1.169 ms 1.128 ms -3.5%
c082e28 5e94541 Change
TOTAL 119.4 ms 115.3 ms -3.5%

@github-actions GitHub Actions
Copy link
Contributor

Click here to check the status of your benchmark.

@github-actions GitHub Actions
Copy link
Contributor

Comparing benchmark results of 'validation-full' on 'c082e28591' (base) and '5e94541fef' (PR)

Results table
Script c082e28 5e94541 Change
auction_1-1 627.5 μs 613.1 μs -2.3%
auction_1-2 2.136 ms 2.099 ms -1.7%
auction_1-3 2.151 ms 2.069 ms -3.8%
auction_1-4 708.5 μs 698.5 μs -1.4%
auction_2-1 628.9 μs 612.8 μs -2.6%
auction_2-2 2.133 ms 2.078 ms -2.6%
auction_2-3 2.491 ms 2.447 ms -1.8%
auction_2-4 2.134 ms 2.091 ms -2.0%
auction_2-5 708.2 μs 698.1 μs -1.4%
crowdfunding-success-1 762.2 μs 744.4 μs -2.3%
crowdfunding-success-2 763.1 μs 743.8 μs -2.5%
crowdfunding-success-3 762.5 μs 744.5 μs -2.4%
currency-1 827.2 μs 818.2 μs -1.1%
escrow-redeem_1-1 1.151 ms 1.119 ms -2.8%
escrow-redeem_1-2 1.151 ms 1.117 ms -3.0%
escrow-redeem_2-1 1.248 ms 1.219 ms -2.3%
escrow-redeem_2-2 1.247 ms 1.218 ms -2.3%
escrow-redeem_2-3 1.251 ms 1.218 ms -2.6%
escrow-refund-1 827.6 μs 791.2 μs -4.4%
future-increase-margin-1 826.8 μs 807.9 μs -2.3%
future-increase-margin-2 1.474 ms 1.452 ms -1.5%
future-increase-margin-3 1.473 ms 1.452 ms -1.4%
future-increase-margin-4 2.142 ms 2.072 ms -3.3%
future-increase-margin-5 2.733 ms 2.658 ms -2.7%
future-pay-out-1 826.9 μs 808.3 μs -2.2%
future-pay-out-2 1.472 ms 1.451 ms -1.4%
future-pay-out-3 1.474 ms 1.449 ms -1.7%
future-pay-out-4 2.730 ms 2.673 ms -2.1%
future-settle-early-1 827.1 μs 817.7 μs -1.1%
future-settle-early-2 1.474 ms 1.452 ms -1.5%
future-settle-early-3 1.473 ms 1.451 ms -1.5%
future-settle-early-4 2.340 ms 2.258 ms -3.5%
game-sm-success_1-1 1.630 ms 1.592 ms -2.3%
game-sm-success_1-2 607.3 μs 592.7 μs -2.4%
game-sm-success_1-3 2.097 ms 2.043 ms -2.6%
game-sm-success_1-4 656.2 μs 593.3 μs -9.6%
game-sm-success_2-1 1.631 ms 1.590 ms -2.5%
game-sm-success_2-2 607.8 μs 593.4 μs -2.4%
game-sm-success_2-3 2.095 ms 2.059 ms -1.7%
game-sm-success_2-4 656.7 μs 593.1 μs -9.7%
game-sm-success_2-5 2.095 ms 2.041 ms -2.6%
game-sm-success_2-6 657.8 μs 594.3 μs -9.7%
multisig-sm-1 1.767 ms 1.699 ms -3.8%
multisig-sm-2 1.749 ms 1.701 ms -2.7%
multisig-sm-3 1.757 ms 1.709 ms -2.7%
multisig-sm-4 1.765 ms 1.716 ms -2.8%
multisig-sm-5 2.067 ms 2.006 ms -3.0%
multisig-sm-6 1.767 ms 1.702 ms -3.7%
multisig-sm-7 1.749 ms 1.681 ms -3.9%
multisig-sm-8 1.760 ms 1.691 ms -3.9%
multisig-sm-9 1.767 ms 1.716 ms -2.9%
multisig-sm-10 2.064 ms 2.000 ms -3.1%
ping-pong-1 1.460 ms 1.407 ms -3.6%
ping-pong-2 1.460 ms 1.408 ms -3.6%
ping-pong_2-1 1.235 ms 1.191 ms -3.6%
prism-1 551.0 μs 539.8 μs -2.0%
prism-2 1.661 ms 1.605 ms -3.4%
prism-3 1.022 ms 1.006 ms -1.6%
pubkey-1 512.5 μs 487.4 μs -4.9%
stablecoin_1-1 3.314 ms 3.209 ms -3.2%
stablecoin_1-2 601.1 μs 586.0 μs -2.5%
stablecoin_1-3 3.580 ms 3.493 ms -2.4%
stablecoin_1-4 615.2 μs 609.9 μs -0.9%
stablecoin_1-5 4.179 ms 4.130 ms -1.2%
stablecoin_1-6 688.6 μs 687.3 μs -0.2%
stablecoin_2-1 3.321 ms 3.210 ms -3.3%
stablecoin_2-2 599.8 μs 586.2 μs -2.3%
stablecoin_2-3 3.574 ms 3.494 ms -2.2%
stablecoin_2-4 615.8 μs 610.4 μs -0.9%
token-account-1 729.0 μs 715.6 μs -1.8%
token-account-2 928.4 μs 907.9 μs -2.2%
uniswap-1 1.099 ms 1.088 ms -1.0%
uniswap-2 785.2 μs 769.1 μs -2.1%
uniswap-3 4.550 ms 4.501 ms -1.1%
uniswap-4 845.2 μs 836.8 μs -1.0%
uniswap-5 3.379 ms 3.318 ms -1.8%
uniswap-6 823.0 μs 819.9 μs -0.4%
vesting-1 1.168 ms 1.138 ms -2.6%
c082e28 5e94541 Change
TOTAL 119.2 ms 116.2 ms -2.5%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@effectfully effectfully

Labels
Evaluation Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@effectfully