Use pytest_subtests for grouped tests
#2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added pytest-subtests version 0.13.1 to the dependencies in pyproject.toml and poetry.lock. This package provides unittest subTest() support and subtests fixture, enhancing the testing capabilities.
Use pytest_subtests for grouped tests that are supposed to run on the same pytest worker. - Introduced pytest_subtests to `test_pools.py` and `test_tx_many_utxos.py` - Refactored `test_stake_pool_cost` to use subtests for different pool costs - Refactored `test_mini_transactions` to use subtests for different amounts - Removed xdist_group marker from `TestManyUTXOs` and `TestPoolCost` classes
Added a new test class `TestSubtests` to verify outcomes using subtests.
mkoura
force-pushed
the
use_subtest_for_grouped
branch
from
6d515dc
to
538aba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use custom xdist scheduler and
xdist_markerfor grouping tests that should run on the same Pytest worker. That is needed e.g. when we want to share expensive setup between several tests.However in some cases this grouping is not enough. Consider hypothetical scenario where we want to reconfigure dbsync and run several tests with the changed configuration. We wouldn't know if the last marked test already finished, and so we don't know when we can return dbsync to its original configuration. We would need to respin the whole cluster instance (using cluster manager). With subtests approach, we can have a single test where a fixture does the setup (reconfiguration) and teardown (back to original) of the dbsync configuration. All the individual tests are just subtests.