Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spread concat cannot be converted to ecmascript3 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jimdigriz
Copy link

@jimdigriz jimdigriz commented Aug 15, 2019

Using --language_out=ECMASCRIPT3 with closure pops up the following error:

../Open-Measurement-JSClients/src/common/logger.js:11: ERROR - [JSC_CANNOT_CONVERT] This code cannot be converted from ES6. "..." passed to a constructor (consider using --language_out=ES5)
        throw new Error('Could not complete the test successfully - ', ...args);
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

PR massages code so it can be converted to ECMASCRIPT3

@Prestonkayla5
Copy link

Using --language_out=ECMASCRIPT3 with closure pops up the following error:


../Open-Measurement-JSClients/src/common/logger.js:11: ERROR - [JSC_CANNOT_CONVERT] This code cannot be converted from ES6. "..." passed to a constructor (consider using --language_out=ES5)

        throw new Error('Could not complete the test successfully - ', ...args);

              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

PR massages code so it can be converted to ECMASCRIPT3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants