Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRE-2420] Upgrade Gemstash to v2.1.0 #13

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

zacblazic
Copy link
Member

@zacblazic zacblazic commented May 10, 2022

Overview

Came to update the changelog for #12, ended up updating everything else too. 🤷🏼

Local Testing

PostgreSQL

$ docker compose logs gemstash
gemstash_1  | Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
gemstash_1  | Starting gemstash!
gemstash_1  | [2022-05-10 09:45:51 +0000] - INFO - [8] Puma starting in cluster mode...
gemstash_1  | [2022-05-10 09:45:51 +0000] - INFO - [8] * Version 4.3.12 (ruby 3.1.2-p20), codename: Mysterious Traveller
gemstash_1  | [2022-05-10 09:45:51 +0000] - INFO - [8] * Min threads: 0, max threads: 4
gemstash_1  | [2022-05-10 09:45:51 +0000] - INFO - [8] * Environment: production
gemstash_1  | [2022-05-10 09:45:51 +0000] - INFO - [8] * Process workers: 1
gemstash_1  | [2022-05-10 09:45:51 +0000] - INFO - [8] * Phased restart available
gemstash_1  | [2022-05-10 09:45:51 +0000] - INFO - [8] * Listening on tcp://0.0.0.0:9292
gemstash_1  | [2022-05-10 09:45:51 +0000] - INFO - [8] Use Ctrl-C to stop
gemstash_1  | [2022-05-10 09:45:51 +0000] - INFO - [8] - Worker 0 (pid: 9) booted, phase: 0

MySQL

$ docker compose logs gemstash
gemstash_1  | Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
gemstash_1  | Starting gemstash!
gemstash_1  | [2022-05-10 10:00:35 +0000] - INFO - [7] Puma starting in cluster mode...
gemstash_1  | [2022-05-10 10:00:35 +0000] - INFO - [7] * Version 4.3.12 (ruby 3.1.2-p20), codename: Mysterious Traveller
gemstash_1  | [2022-05-10 10:00:35 +0000] - INFO - [7] * Min threads: 0, max threads: 4
gemstash_1  | [2022-05-10 10:00:35 +0000] - INFO - [7] * Environment: production
gemstash_1  | [2022-05-10 10:00:35 +0000] - INFO - [7] * Process workers: 1
gemstash_1  | [2022-05-10 10:00:35 +0000] - INFO - [7] * Phased restart available
gemstash_1  | [2022-05-10 10:00:35 +0000] - INFO - [7] * Listening on tcp://0.0.0.0:9292
gemstash_1  | [2022-05-10 10:00:35 +0000] - INFO - [7] Use Ctrl-C to stop
gemstash_1  | [2022-05-10 10:00:35 +0000] - INFO - [7] - Worker 0 (pid: 8) booted, phase: 0

SQLite

$ docker compose logs gemstash
gemstash_1  | Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
gemstash_1  | Starting gemstash!
gemstash_1  | [2022-05-10 10:01:12 +0000] - INFO - [9] Puma starting in cluster mode...
gemstash_1  | [2022-05-10 10:01:12 +0000] - INFO - [9] * Version 4.3.12 (ruby 3.1.2-p20), codename: Mysterious Traveller
gemstash_1  | [2022-05-10 10:01:12 +0000] - INFO - [9] * Min threads: 0, max threads: 16
gemstash_1  | [2022-05-10 10:01:12 +0000] - INFO - [9] * Environment: production
gemstash_1  | [2022-05-10 10:01:12 +0000] - INFO - [9] * Process workers: 1
gemstash_1  | [2022-05-10 10:01:12 +0000] - INFO - [9] * Phased restart available
gemstash_1  | [2022-05-10 10:01:12 +0000] - INFO - [9] * Listening on tcp://0.0.0.0:9292
gemstash_1  | [2022-05-10 10:01:12 +0000] - INFO - [9] Use Ctrl-C to stop
gemstash_1  | [2022-05-10 10:01:12 +0000] - INFO - [9] - Worker 0 (pid: 10) booted, phase: 0

@zacblazic zacblazic requested a review from a team as a code owner May 10, 2022 09:54
@itskingori
Copy link
Member

LGTM to me but just have two questions:

  • Is it working locally?
  • What's the plan to test or we snapshot and just roll it out to production?

@zacblazic
Copy link
Member Author

LGTM to me but just have two questions:

  • Is it working locally?

Yeah, Gemstash starts up successfully when backed by all storage types (see description).

  • What's the plan to test or we snapshot and just roll it out to production?

I'll perform some basic tests locally i.e. uploading and fetching a gem.

@zacblazic zacblazic requested a review from a team May 10, 2022 10:23
Copy link
Member

@itskingori itskingori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. SGTM ...👌🏽

@zacblazic
Copy link
Member Author

I'll perform some basic tests locally i.e. uploading and fetching a gem.

Hitting some snags when attempting to upload a gem:

$ gem push --key gemstash_dev --host http://localhost:9292/private pkg/test-0.1.0.gem
Pushing gem to http://localhost:9292/private...
Authorization key is invalid

Going to come back to this later.

@itskingori
Copy link
Member

Needs rebase to resolve conflicts.

@zacblazic zacblazic changed the title Upgrade Gemstash to v2.1.0 [SRE-2420] Upgrade Gemstash to v2.1.0 Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants