Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for dpex failure caused by addition of nin, nout and types #1434

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Fix for dpex failure caused by addition of nin, nout and types #1434

merged 2 commits into from
Apr 17, 2024

Conversation

adarshyoga
Copy link
Collaborator

@adarshyoga adarshyoga commented Apr 10, 2024 •
edited by diptorupd
Loading

  • Have you provided a meaningful PR description?

Fix for dpnp ufunc db creation caused by addition of nin, nout and types to dpnp math functions in latest version of dpnp.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.065% (-0.2%) from 87.215%
when pulling c793313 on fix/dpnp_nin_issue
into 1336f76 on main.

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@diptorupd diptorupd merged commit 4708ac7 into main Apr 17, 2024
56 of 64 checks passed
@diptorupd diptorupd deleted the fix/dpnp_nin_issue branch April 17, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd left review comments

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adarshyoga @coveralls @diptorupd @oleksandr-pavlyk