Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect required numpy version in Pypi json #1942

Open
icfaust opened this issue Jul 24, 2024 · 4 comments
Open

Reflect required numpy version in Pypi json #1942

icfaust opened this issue Jul 24, 2024 · 4 comments

Comments

@icfaust
Copy link

icfaust commented Jul 24, 2024

While the listed numpy version is available here: https://github.com/IntelPython/dpnp and here: https://pypi.org/project/dpnp/, when installed it is up to the user to check this when installing from pip. Please adapt the published json here: https://pypi.org/pypi/dpnp/json the "required_dist" should be ["dpctl","dpcpp-cpp-rt","mkl-dpcpp","numpy<1.25a0,>=1.19"] instead of ["dpctl","dpcpp-cpp-rt","mkl-dpcpp","numpy"] . This will make this requirement enforced on dpnp installation from pip.

@icfaust
Copy link
Author

icfaust commented Oct 31, 2024

@antonwolfy Any news on this? It seems that the pypi information for the release a couple days ago is the same.

@antonwolfy
Copy link
Contributor

@icfaust , it was intentional, because dpnp from 0.16.0 release can work now with any numpy version, including numpy>2.0.

@icfaust
Copy link
Author

icfaust commented Nov 4, 2024

@antonwolfy then the documentation on pypi is wrong for build from source

@antonwolfy
Copy link
Contributor

antonwolfy commented Nov 4, 2024

@icfaust, I see, thank you for noticing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants