Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: implement array_api linalg support for dpctl tensors #1715

Open
icfaust opened this issue Jun 19, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@icfaust
Copy link

icfaust commented Jun 19, 2024

dpctl tensors implement most of the array_api standard except for the linalg package as shown by this deselection file: https://github.com/IntelPython/dpctl/blob/master/.github/workflows/array-api-skips.txt

This causes issues in using dpctl tensors with scikit-learn, an example being with PCA which requires the linalg.svd method. Would it be possible to implement these functions as per the array api specification in dpctl (https://data-apis.org/array-api/2023.12/extensions/linear_algebra_functions.html)?

@ndgrigorian ndgrigorian self-assigned this Jun 20, 2024
@ndgrigorian
Copy link
Collaborator

ndgrigorian commented Jun 25, 2024

Both this and FFT are things we're working towards supporting in the future.

It would currently be theoretically possible with array API functions and some dedicated kernels, but we're still working toward a satisfying submodule implementation.

@oleksandr-pavlyk oleksandr-pavlyk added the enhancement New feature or request label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants