Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure module to adhere to new GitHub Actions #159

Closed
6 of 7 tasks
mseng10 opened this issue May 18, 2020 · 1 comment · Fixed by #209
Closed
6 of 7 tasks

Configure module to adhere to new GitHub Actions #159

mseng10 opened this issue May 18, 2020 · 1 comment · Fixed by #209

Comments

@mseng10
Copy link
Collaborator

mseng10 commented May 18, 2020

This issue contains the actions needed for this module in relation to it's parent issue here. This will require the following changes:

  • Remove Azure Pipeline testing and update README
  • Import GitHub Actions configuration files and implement them into ITKExamples. Also, update the README with the GitHub Actions badge.
  • Make PR.
  • Make all CXX builds pass
  • Make all Python builds pass
  • Make Sphinx Documentation build
  • Deploy documentation to website with Netlify

NOTE: When configuring this module to adhere to the new GitHub Actions, there are a few differences between this module and the ITKModuleTemplate. These are stated below.

  1. No setup.py script
  2. No PyPI package for ITKExamples

@hjmjohnson @thewtex For this module, I am confused as to the required GitHub Actions needed. Are we taking special actions for this module? If so, can either of you help direct me to the actions needed? Any help would be greatly appreciated.

@thewtex
Copy link
Member

thewtex commented May 19, 2020

@mseng10 thanks for taking this on 🙏

Cross-platform builds for the examples is a good way to get started.

After the build are working, good next steps are to add documentation builds (bring in #97).

Then, add also a website deploy preview, e.g. with Netlify.

https://github.com/netlify/actions

@mseng10 mseng10 mentioned this issue May 19, 2020
thewtex added a commit that referenced this issue Feb 26, 2021
Deploy previews and publish on master for https://itkexamples.netlify.app

Closes #159
thewtex added a commit that referenced this issue Feb 26, 2021
Deploy previews and publish on master for https://itkexamples.netlify.app

Closes #159
thewtex added a commit that referenced this issue Feb 26, 2021
Deploy previews and publish on master for https://itkexamples.netlify.app

Closes #159
thewtex added a commit that referenced this issue Feb 26, 2021
Deploy previews and publish on master for https://itkexamples.netlify.app

Closes #159
thewtex added a commit that referenced this issue Feb 26, 2021
Deploy previews and publish on master for https://itkexamples.netlify.app

Closes #159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants